Re: [PATCH 5/5] hw: Remove mentions of NDEBUG

2023-02-22 Thread Michael S. Tsirkin
On Wed, Feb 22, 2023 at 08:43:35AM -1000, Richard Henderson wrote: > On 2/22/23 06:28, Michael S. Tsirkin wrote: > > On Wed, Feb 22, 2023 at 05:11:36PM +0100, Philippe Mathieu-Daudé wrote: > > > On 22/2/23 13:05, Michael S. Tsirkin wrote: > > > > On Wed, Feb 22, 2023 at 12:25:20AM +0100, Philippe M

Re: [PATCH 5/5] hw: Remove mentions of NDEBUG

2023-02-22 Thread Richard Henderson
On 2/22/23 06:28, Michael S. Tsirkin wrote: On Wed, Feb 22, 2023 at 05:11:36PM +0100, Philippe Mathieu-Daudé wrote: On 22/2/23 13:05, Michael S. Tsirkin wrote: On Wed, Feb 22, 2023 at 12:25:20AM +0100, Philippe Mathieu-Daudé wrote: Since commit 262a69f428 ("osdep.h: Prohibit disabling assert()

Re: [PATCH 5/5] hw: Remove mentions of NDEBUG

2023-02-22 Thread Michael S. Tsirkin
On Wed, Feb 22, 2023 at 05:11:36PM +0100, Philippe Mathieu-Daudé wrote: > On 22/2/23 13:05, Michael S. Tsirkin wrote: > > On Wed, Feb 22, 2023 at 12:25:20AM +0100, Philippe Mathieu-Daudé wrote: > > > Since commit 262a69f428 ("osdep.h: Prohibit disabling > > > assert() in supported builds") 'NDEBUG'

Re: [PATCH 5/5] hw: Remove mentions of NDEBUG

2023-02-22 Thread Philippe Mathieu-Daudé
On 22/2/23 13:05, Michael S. Tsirkin wrote: On Wed, Feb 22, 2023 at 12:25:20AM +0100, Philippe Mathieu-Daudé wrote: Since commit 262a69f428 ("osdep.h: Prohibit disabling assert() in supported builds") 'NDEBUG' can not be defined. Signed-off-by: Philippe Mathieu-Daudé this exactly says NDEBUG

Re: [PATCH 5/5] hw: Remove mentions of NDEBUG

2023-02-22 Thread Michael S. Tsirkin
On Wed, Feb 22, 2023 at 12:25:20AM +0100, Philippe Mathieu-Daudé wrote: > Since commit 262a69f428 ("osdep.h: Prohibit disabling > assert() in supported builds") 'NDEBUG' can not be defined. > > Signed-off-by: Philippe Mathieu-Daudé this exactly says NDEBUG is not allowed. why are you removing th

Re: [PATCH 5/5] hw: Remove mentions of NDEBUG

2023-02-21 Thread Richard Henderson
On 2/21/23 13:25, Philippe Mathieu-Daudé wrote: Since commit 262a69f428 ("osdep.h: Prohibit disabling assert() in supported builds") 'NDEBUG' can not be defined. Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/mptsas.c | 2 -- hw/virtio/virtio.c | 2 -- 2 files changed, 4 deletions(-)

[PATCH 5/5] hw: Remove mentions of NDEBUG

2023-02-21 Thread Philippe Mathieu-Daudé
Since commit 262a69f428 ("osdep.h: Prohibit disabling assert() in supported builds") 'NDEBUG' can not be defined. Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/mptsas.c | 2 -- hw/virtio/virtio.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c inde