Re: [PATCH 5/5] migration/multifd: Add a synchronization point for channel creation

2024-02-05 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Feb 05, 2024 at 01:10:14PM +0200, Avihai Horon wrote: >> >> On 05/02/2024 8:20, Peter Xu wrote: >> > External email: Use caution opening links or attachments >> > >> > >> > On Fri, Feb 02, 2024 at 04:11:28PM -0300, Fabiano Rosas wrote: >> > > It is possible that one

Re: [PATCH 5/5] migration/multifd: Add a synchronization point for channel creation

2024-02-05 Thread Peter Xu
On Mon, Feb 05, 2024 at 01:10:14PM +0200, Avihai Horon wrote: > > On 05/02/2024 8:20, Peter Xu wrote: > > External email: Use caution opening links or attachments > > > > > > On Fri, Feb 02, 2024 at 04:11:28PM -0300, Fabiano Rosas wrote: > > > It is possible that one of the multifd channels fail

Re: [PATCH 5/5] migration/multifd: Add a synchronization point for channel creation

2024-02-05 Thread Avihai Horon
On 05/02/2024 8:20, Peter Xu wrote: External email: Use caution opening links or attachments On Fri, Feb 02, 2024 at 04:11:28PM -0300, Fabiano Rosas wrote: It is possible that one of the multifd channels fails to be created at multifd_new_send_channel_async() while the rest of the channel cr

Re: [PATCH 5/5] migration/multifd: Add a synchronization point for channel creation

2024-02-04 Thread Peter Xu
On Fri, Feb 02, 2024 at 04:11:28PM -0300, Fabiano Rosas wrote: > It is possible that one of the multifd channels fails to be created at > multifd_new_send_channel_async() while the rest of the channel > creation tasks are still in flight. > > This could lead to multifd_save_cleanup() executing the

[PATCH 5/5] migration/multifd: Add a synchronization point for channel creation

2024-02-02 Thread Fabiano Rosas
It is possible that one of the multifd channels fails to be created at multifd_new_send_channel_async() while the rest of the channel creation tasks are still in flight. This could lead to multifd_save_cleanup() executing the qemu_thread_join() loop too early and not waiting for the threads which