Re: [PATCH 5/5] util/qsp: Do not declare local variable only used for assertion

2020-09-02 Thread Philippe Mathieu-Daudé
On 9/2/20 11:11 AM, Greg Kurz wrote: > On Wed, 2 Sep 2020 10:08:01 +0200 > Philippe Mathieu-Daudé wrote: > >> This variable is used once in an assertion. Remove single >> declaration and access directly in the assert(). >> >> See in "qemu/osdep.h": >> >> *

Re: [PATCH 5/5] util/qsp: Do not declare local variable only used for assertion

2020-09-02 Thread Greg Kurz
On Wed, 2 Sep 2020 10:08:01 +0200 Philippe Mathieu-Daudé wrote: > This variable is used once in an assertion. Remove single > declaration and access directly in the assert(). > > See in "qemu/osdep.h": > > * [...] disable assertion is not > * supported

[PATCH 5/5] util/qsp: Do not declare local variable only used for assertion

2020-09-02 Thread Philippe Mathieu-Daudé
This variable is used once in an assertion. Remove single declaration and access directly in the assert(). See in "qemu/osdep.h": * [...] disable assertion is not * supported upstream so the risk is all yours. Meanwhile, please * submit patches to remove any