Re: [PATCH 5/6] qga: Add timeout for fsfreeze

2023-10-30 Thread Konstantin Kostiuk
On Mon, Oct 30, 2023 at 6:32 PM Alexander Ivanov < alexander.iva...@virtuozzo.com> wrote: > > > On 10/26/23 11:16, Konstantin Kostiuk wrote: > > > > I think it is better to check that timeout <= 10 sec in the case of > > Windows. > > Anyway this is a VSS limitation and FS will be unfrozen earlier

Re: [PATCH 5/6] qga: Add timeout for fsfreeze

2023-10-30 Thread Alexander Ivanov
On 10/26/23 11:16, Konstantin Kostiuk wrote: I think it is better to check that timeout <= 10 sec in the case of Windows. Anyway this is a VSS limitation and FS will be unfrozen earlier if timeout > 10 sec, this can cause some misunderstanding from a user. Thank you, will pay attention.

Re: [PATCH 5/6] qga: Add timeout for fsfreeze

2023-10-26 Thread Konstantin Kostiuk
I think it is better to check that timeout <= 10 sec in the case of Windows. Anyway this is a VSS limitation and FS will be unfrozen earlier if timeout > 10 sec, this can cause some misunderstanding from a user. timeout option sounds good in the guest-fsfreeze-freeze command. In

[PATCH 5/6] qga: Add timeout for fsfreeze

2023-10-25 Thread Alexander Ivanov
In some cases it would be useful to thaw a filesystem by timeout after freezing this filesystem by guest-fsfreeze-freeze-list. Add an optional argument "timeout" to the command. Signed-off-by: Alexander Ivanov --- qga/commands-posix.c | 21 ++--- qga/commands-win32.c | 16