On 1/19/20 11:01 AM, Peter Maydell wrote:
On Sun, 19 Jan 2020 at 01:52, Guenter Roeck wrote:
I'd rather try to fix it all if I am at it; otherwise it feels kind
of incomplete. Would you be ok with addressing this separately after
the current patch series is accepted ?
Absolutely, if you'd
On Sun, 19 Jan 2020 at 01:52, Guenter Roeck wrote:
> I'd rather try to fix it all if I am at it; otherwise it feels kind
> of incomplete. Would you be ok with addressing this separately after
> the current patch series is accepted ?
Absolutely, if you'd like to clean up the code please feel
On 1/18/20 12:02 PM, Peter Maydell wrote:
On Sat, 18 Jan 2020 at 15:08, Guenter Roeck wrote:
Do only the pointers have to be in Exynos4210State, or the entire
data structures ? In the armsse code it looks like it is the complete
data structures.
Either works. Embedding the entire data
On Sat, 18 Jan 2020 at 15:08, Guenter Roeck wrote:
> Do only the pointers have to be in Exynos4210State, or the entire
> data structures ? In the armsse code it looks like it is the complete
> data structures.
Either works. Embedding the entire data structure is the more
"modern" approach, but
On 1/17/20 10:44 AM, Peter Maydell wrote:
On Fri, 17 Jan 2020 at 18:29, Guenter Roeck wrote:
[ ... ]
Rather than having the uart and pl330 pointers be locals,
they should be fields in Exynos4210State. (Otherwise technically
we leak them, though this is unnoticeable in practice because there's
On Fri, 17 Jan 2020 at 18:29, Guenter Roeck wrote:
>
> On Fri, Jan 17, 2020 at 01:48:06PM +, Peter Maydell wrote:
> > On Fri, 10 Jan 2020 at 20:39, Guenter Roeck wrote:
> > >
> > > The Exynos4210 serial driver uses an interrupt line to signal if receive
> > > data is available. Connect that
On Fri, Jan 17, 2020 at 01:48:06PM +, Peter Maydell wrote:
> On Fri, 10 Jan 2020 at 20:39, Guenter Roeck wrote:
> >
> > The Exynos4210 serial driver uses an interrupt line to signal if receive
> > data is available. Connect that interrupt with the DMA controller's
> > 'peripheral busy' gpio
On Fri, 10 Jan 2020 at 20:39, Guenter Roeck wrote:
>
> The Exynos4210 serial driver uses an interrupt line to signal if receive
> data is available. Connect that interrupt with the DMA controller's
> 'peripheral busy' gpio pin.
>
> Signed-off-by: Guenter Roeck
> ---
> hw/arm/exynos4210.c | 39
The Exynos4210 serial driver uses an interrupt line to signal if receive
data is available. Connect that interrupt with the DMA controller's
'peripheral busy' gpio pin.
Signed-off-by: Guenter Roeck
---
hw/arm/exynos4210.c | 39 ++-
1 file changed, 26
