Re: [PATCH 6/6] hw/s390x: Clean up global variable shadowing in quiesce_powerdown_req()

2023-10-11 Thread Eric Farman
On Mon, 2023-10-09 at 11:47 +0200, Philippe Mathieu-Daudé wrote: > Fix: > >   hw/s390x/sclpquiesce.c:90:22: error: declaration shadows a variable > in the global scope [-Werror,-Wshadow] >   QuiesceNotifier *qn = container_of(n, QuiesceNotifier, > notifier); >    ^ >   hw/s

Re: [PATCH 6/6] hw/s390x: Clean up global variable shadowing in quiesce_powerdown_req()

2023-10-09 Thread David Hildenbrand
On 09.10.23 11:47, Philippe Mathieu-Daudé wrote: Fix: hw/s390x/sclpquiesce.c:90:22: error: declaration shadows a variable in the global scope [-Werror,-Wshadow] QuiesceNotifier *qn = container_of(n, QuiesceNotifier, notifier); ^ hw/s390x/sclpquiesce.c:86:3:

Re: [PATCH 6/6] hw/s390x: Clean up global variable shadowing in quiesce_powerdown_req()

2023-10-09 Thread Thomas Huth
On 09/10/2023 11.47, Philippe Mathieu-Daudé wrote: Fix: hw/s390x/sclpquiesce.c:90:22: error: declaration shadows a variable in the global scope [-Werror,-Wshadow] QuiesceNotifier *qn = container_of(n, QuiesceNotifier, notifier); ^ hw/s390x/sclpquiesce.c:86:3

[PATCH 6/6] hw/s390x: Clean up global variable shadowing in quiesce_powerdown_req()

2023-10-09 Thread Philippe Mathieu-Daudé
Fix: hw/s390x/sclpquiesce.c:90:22: error: declaration shadows a variable in the global scope [-Werror,-Wshadow] QuiesceNotifier *qn = container_of(n, QuiesceNotifier, notifier); ^ hw/s390x/sclpquiesce.c:86:3: note: previous declaration is here } qn; ^ Signe