Re: [PATCH 6/6] monitor: convert monitor_cleanup() to AIO_WAIT_WHILE_UNLOCKED()

2023-03-07 Thread Philippe Mathieu-Daudé
On 1/3/23 21:58, Stefan Hajnoczi wrote: monitor_cleanup() is called from the main loop thread. Calling AIO_WAIT_WHILE(qemu_get_aio_context(), ...) from the main loop thread is equivalent to AIO_WAIT_WHILE_UNLOCKED(NULL, ...) because neither unlocks the AioContext and the latter's assertion that w

Re: [PATCH 6/6] monitor: convert monitor_cleanup() to AIO_WAIT_WHILE_UNLOCKED()

2023-03-02 Thread Markus Armbruster
Markus Armbruster writes: > Stefan Hajnoczi writes: > >> monitor_cleanup() is called from the main loop thread. Calling > > Correct. > >> AIO_WAIT_WHILE(qemu_get_aio_context(), ...) from the main loop thread is >> equivalent to AIO_WAIT_WHILE_UNLOCKED(NULL, ...) because neither unlocks >> the Ai

Re: [PATCH 6/6] monitor: convert monitor_cleanup() to AIO_WAIT_WHILE_UNLOCKED()

2023-03-01 Thread Markus Armbruster
Stefan Hajnoczi writes: > monitor_cleanup() is called from the main loop thread. Calling Correct. > AIO_WAIT_WHILE(qemu_get_aio_context(), ...) from the main loop thread is > equivalent to AIO_WAIT_WHILE_UNLOCKED(NULL, ...) because neither unlocks > the AioContext and the latter's assertion tha

[PATCH 6/6] monitor: convert monitor_cleanup() to AIO_WAIT_WHILE_UNLOCKED()

2023-03-01 Thread Stefan Hajnoczi
monitor_cleanup() is called from the main loop thread. Calling AIO_WAIT_WHILE(qemu_get_aio_context(), ...) from the main loop thread is equivalent to AIO_WAIT_WHILE_UNLOCKED(NULL, ...) because neither unlocks the AioContext and the latter's assertion that we're in the main loop succeeds. Signed-of