Re: [PATCH 6/6] target/ppc: Don't update radix PTE R/C bits with gdbstub

2020-05-11 Thread Greg Kurz
On Mon, 11 May 2020 11:43:48 +1000 David Gibson wrote: > On Thu, May 07, 2020 at 07:27:15PM +0200, Greg Kurz wrote: > > gdbstub shouldn't silently change guest visible state when doing address > > translation. While here drop a not very useful comment. > > > > This was found while reading the

Re: [PATCH 6/6] target/ppc: Don't update radix PTE R/C bits with gdbstub

2020-05-10 Thread David Gibson
On Thu, May 07, 2020 at 07:27:15PM +0200, Greg Kurz wrote: > gdbstub shouldn't silently change guest visible state when doing address > translation. While here drop a not very useful comment. > > This was found while reading the code. I could verify that this affects > both powernv and pseries,

[PATCH 6/6] target/ppc: Don't update radix PTE R/C bits with gdbstub

2020-05-07 Thread Greg Kurz
gdbstub shouldn't silently change guest visible state when doing address translation. While here drop a not very useful comment. This was found while reading the code. I could verify that this affects both powernv and pseries, but I failed to observe any actual bug. Fixes: d04ea940c597