On Mon, Jul 15, 2024 at 02:07:00PM +0300, Michael Tokarev wrote:
> Date: Mon, 15 Jul 2024 14:07:00 +0300
> From: Michael Tokarev
> Subject: Re: [PATCH 7/7] backends/rng-random: Get rid of qemu_open_old()
>
> 15.07.2024 13:10, Zhao Liu wrote:
> ...
> > Thanks Philippe! I&#
15.07.2024 13:10, Zhao Liu wrote:
...
Thanks Philippe! I'll wait patch 1's comment, after that I can post a
new version with the change you mentioned.
I don't think either of this is necessary. Patch 1 LGTM, and I'll
drop the comment while applying.
/mjt
--
GPG Key transition (from rsa2048 t
On Mon, Jul 15, 2024 at 11:46:54AM +0200, Philippe Mathieu-Daudé wrote:
> Date: Mon, 15 Jul 2024 11:46:54 +0200
> From: Philippe Mathieu-Daudé
> Subject: Re: [PATCH 7/7] backends/rng-random: Get rid of qemu_open_old()
>
> On 15/7/24 10:21, Zhao Liu wrote:
> > For qemu_ope
On 15/7/24 10:21, Zhao Liu wrote:
For qemu_open_old(), osdep.h said:
Don't introduce new usage of this function, prefer the following
qemu_open/qemu_create that take an "Error **errp".
So replace qemu_open_old() with qemu_open(). And considering
rng_random_opened() will lose its obvious error
For qemu_open_old(), osdep.h said:
> Don't introduce new usage of this function, prefer the following
> qemu_open/qemu_create that take an "Error **errp".
So replace qemu_open_old() with qemu_open(). And considering
rng_random_opened() will lose its obvious error handling case after
removing erro
