Re: [PATCH 7/7] libvhost-user: Switch to unsigned int for inuse field in struct VuVirtq

2022-12-20 Thread Marcel Holtmann
Hi Michael, >> It seems there is no need to keep the inuse field signed and end up with >> compiler warnings for sign-compare. >> >> CC libvhost-user.o >> libvhost-user.c: In function ‘vu_queue_pop’: >> libvhost-user.c:2763:19: error: comparison of integer expressions of >> different sign

Re: [PATCH 7/7] libvhost-user: Switch to unsigned int for inuse field in struct VuVirtq

2022-12-20 Thread Michael S. Tsirkin
On Mon, Dec 19, 2022 at 06:53:37PM +0100, Marcel Holtmann wrote: > It seems there is no need to keep the inuse field signed and end up with > compiler warnings for sign-compare. > > CC libvhost-user.o > libvhost-user.c: In function ‘vu_queue_pop’: > libvhost-user.c:2763:19: error: comparis

Re: [PATCH 7/7] libvhost-user: Switch to unsigned int for inuse field in struct VuVirtq

2022-12-19 Thread Marcel Holtmann
Hi Philippe, >> It seems there is no need to keep the inuse field signed and end up with >> compiler warnings for sign-compare. >> CC libvhost-user.o >> libvhost-user.c: In function ‘vu_queue_pop’: >> libvhost-user.c:2763:19: error: comparison of integer expressions of >> different signed

Re: [PATCH 7/7] libvhost-user: Switch to unsigned int for inuse field in struct VuVirtq

2022-12-19 Thread Philippe Mathieu-Daudé
On 19/12/22 18:53, Marcel Holtmann wrote: It seems there is no need to keep the inuse field signed and end up with compiler warnings for sign-compare. CC libvhost-user.o libvhost-user.c: In function ‘vu_queue_pop’: libvhost-user.c:2763:19: error: comparison of integer expressions of dif

[PATCH 7/7] libvhost-user: Switch to unsigned int for inuse field in struct VuVirtq

2022-12-19 Thread Marcel Holtmann
It seems there is no need to keep the inuse field signed and end up with compiler warnings for sign-compare. CC libvhost-user.o libvhost-user.c: In function ‘vu_queue_pop’: libvhost-user.c:2763:19: error: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’