Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response

2020-10-27 Thread Mark Cave-Ayland
On 26/10/2020 15:04, Samuel Thibault wrote: Mark Cave-Ayland, le lun. 26 oct. 2020 13:40:05 +, a ecrit: On 26/10/2020 13:00, Jason Andryuk wrote: On Mon, Oct 26, 2020 at 7:21 AM Samuel Thibault wrote: Aurelien, you introduced the "| 1" in commit abb8a13918ecc1e8160aa78582de9d5224ea70df

Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response

2020-10-27 Thread Jason Andryuk
On Tue, Oct 27, 2020 at 9:18 AM Mark Cave-Ayland wrote: > > I spent a bit of time this morning doing some further tests on Linux using 2 > machines > and a test program to check CTS and usbmon: > > usbmon when adapter unplugged: > 95a4bf2dd300 2366831506 S Ci:4:004:0 s c0 05 0002 2

Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response

2020-10-26 Thread Samuel Thibault
Mark Cave-Ayland, le lun. 26 oct. 2020 13:40:05 +, a ecrit: > On 26/10/2020 13:00, Jason Andryuk wrote: > > On Mon, Oct 26, 2020 at 7:21 AM Samuel Thibault > > wrote: > > > Aurelien, you introduced the "| 1" in > > > > > > commit abb8a13918ecc1e8160aa78582de9d5224ea70df > > > Author:

Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response

2020-10-26 Thread Jason Andryuk
On Mon, Oct 26, 2020 at 9:40 AM Mark Cave-Ayland wrote: > > On 26/10/2020 13:00, Jason Andryuk wrote: > > > On Mon, Oct 26, 2020 at 7:21 AM Samuel Thibault > > wrote: > >> > >> Mark Cave-Ayland, le lun. 26 oct. 2020 10:58:43 +, a ecrit: > >>> On 26/10/2020 09:54, Samuel Thibault wrote: >

Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response

2020-10-26 Thread Mark Cave-Ayland
On 26/10/2020 13:00, Jason Andryuk wrote: On Mon, Oct 26, 2020 at 7:21 AM Samuel Thibault wrote: Mark Cave-Ayland, le lun. 26 oct. 2020 10:58:43 +, a ecrit: On 26/10/2020 09:54, Samuel Thibault wrote: Mark Cave-Ayland, le lun. 26 oct. 2020 08:34:00 +, a ecrit: The FTDI_GET_MDM_ST

Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response

2020-10-26 Thread Jason Andryuk
On Mon, Oct 26, 2020 at 7:21 AM Samuel Thibault wrote: > > Mark Cave-Ayland, le lun. 26 oct. 2020 10:58:43 +, a ecrit: > > On 26/10/2020 09:54, Samuel Thibault wrote: > > > Mark Cave-Ayland, le lun. 26 oct. 2020 08:34:00 +, a ecrit: > > > > The FTDI_GET_MDM_ST response should only return

Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response

2020-10-26 Thread Samuel Thibault
Mark Cave-Ayland, le lun. 26 oct. 2020 10:58:43 +, a ecrit: > On 26/10/2020 09:54, Samuel Thibault wrote: > > Mark Cave-Ayland, le lun. 26 oct. 2020 08:34:00 +, a ecrit: > > > The FTDI_GET_MDM_ST response should only return a single byte indicating > > > the > > > modem status with bit 0

Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response

2020-10-26 Thread Mark Cave-Ayland
On 26/10/2020 09:54, Samuel Thibault wrote: Hello, (Cc-ing Aurelien who introduced the support for modem control, and Jason who added the missing THRE and TEMT flags). Mark Cave-Ayland, le lun. 26 oct. 2020 08:34:00 +, a ecrit: The FTDI_GET_MDM_ST response should only return a single

Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response

2020-10-26 Thread Samuel Thibault
Hello, (Cc-ing Aurelien who introduced the support for modem control, and Jason who added the missing THRE and TEMT flags). Mark Cave-Ayland, le lun. 26 oct. 2020 08:34:00 +, a ecrit: > The FTDI_GET_MDM_ST response should only return a single byte indicating the > modem status with bit 0

[PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response

2020-10-26 Thread Mark Cave-Ayland
The FTDI_GET_MDM_ST response should only return a single byte indicating the modem status with bit 0 cleared (as documented in the Linux ftdi_sio.h header file). Signed-off-by: Mark Cave-Ayland --- hw/usb/dev-serial.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git