Re: [PATCH 8/9] monitor: move hmp_info_block* to blockdev-hmp-cmds.c

Am 27.01.2020 um 14:33 hat Markus Armbruster geschrieben: > Maxim Levitsky writes: > > > On Wed, 2019-11-27 at 09:08 +0100, Markus Armbruster wrote: > >> I think it makes sense to collect *all* block HMP stuff here. > >> > >> Left in monitor/hmp-cmds.c: hmp_eject(), hmp_nbd_server_start(), ... >

Re: [PATCH 8/9] monitor: move hmp_info_block* to blockdev-hmp-cmds.c

On Mon, 2020-01-27 at 14:33 +0100, Markus Armbruster wrote: > Maxim Levitsky writes: > > > On Wed, 2019-11-27 at 09:08 +0100, Markus Armbruster wrote: > > > I think it makes sense to collect *all* block HMP stuff here. > > > > > > Left in monitor/hmp-cmds.c: hmp_eject(), hmp_nbd_server_start(),

Re: [PATCH 8/9] monitor: move hmp_info_block* to blockdev-hmp-cmds.c

Maxim Levitsky writes: > On Wed, 2019-11-27 at 09:08 +0100, Markus Armbruster wrote: >> I think it makes sense to collect *all* block HMP stuff here. >> >> Left in monitor/hmp-cmds.c: hmp_eject(), hmp_nbd_server_start(), ... >> >> I guess hmp_change() has to stay there, because it's both block

Re: [PATCH 8/9] monitor: move hmp_info_block* to blockdev-hmp-cmds.c

On Wed, 2019-11-27 at 09:08 +0100, Markus Armbruster wrote: > I think it makes sense to collect *all* block HMP stuff here. > > Left in monitor/hmp-cmds.c: hmp_eject(), hmp_nbd_server_start(), ... > > I guess hmp_change() has to stay there, because it's both block and ui. > > Left in blockdev.c:

Re: [PATCH 8/9] monitor: move hmp_info_block* to blockdev-hmp-cmds.c

I think it makes sense to collect *all* block HMP stuff here. Left in monitor/hmp-cmds.c: hmp_eject(), hmp_nbd_server_start(), ... I guess hmp_change() has to stay there, because it's both block and ui. Left in blockdev.c: hmp_drive_add_node(). Quick grep for possible files to check: $ git-gre

[PATCH 8/9] monitor: move hmp_info_block* to blockdev-hmp-cmds.c

Signed-off-by: Maxim Levitsky --- blockdev-hmp-cmds.c | 247 monitor/hmp-cmds.c | 245 --- 2 files changed, 247 insertions(+), 245 deletions(-) diff --git a/blockdev-hmp-cmds.c b/blockdev-hmp-cmds.c index 76951