Re: [PATCH 8/9] plugins: add time control API

2024-06-14 Thread Pierrick Bouvier
On 6/13/24 08:56, Alex Bennée wrote: Philippe Mathieu-Daudé writes: On 12/6/24 17:35, Alex Bennée wrote: Expose the ability to control time through the plugin API. Only one plugin can control time so it has to request control when loaded. There are probably more corner cases to catch here.

Re: [PATCH 8/9] plugins: add time control API

2024-06-13 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 12/6/24 17:35, Alex Bennée wrote: >> Expose the ability to control time through the plugin API. Only one >> plugin can control time so it has to request control when loaded. >> There are probably more corner cases to catch here. >> From: Alex Bennée > > Some

Re: [PATCH 8/9] plugins: add time control API

2024-06-13 Thread Philippe Mathieu-Daudé
On 12/6/24 17:35, Alex Bennée wrote: Expose the ability to control time through the plugin API. Only one plugin can control time so it has to request control when loaded. There are probably more corner cases to catch here. From: Alex Bennée Some of your patches include this dubious From:

Re: [PATCH 8/9] plugins: add time control API

2024-06-12 Thread Pierrick Bouvier
On 6/12/24 12:37, Alex Bennée wrote: Pierrick Bouvier writes: Hi Alex, I noticed the new symbols lack QEMU_PLUGIN_API qualifier in include/qemu/qemu-plugin.h: - qemu_plugin_update_ns - qemu_plugin_request_time_control So it would be impossible to use those symbols on windows. I kept a

Re: [PATCH 8/9] plugins: add time control API

2024-06-12 Thread Alex Bennée
Pierrick Bouvier writes: > Hi Alex, > > I noticed the new symbols lack QEMU_PLUGIN_API qualifier in > include/qemu/qemu-plugin.h: > - qemu_plugin_update_ns > - qemu_plugin_request_time_control > > So it would be impossible to use those symbols on windows. > > I kept a reminder to send a new

Re: [PATCH 8/9] plugins: add time control API

2024-06-12 Thread Pierrick Bouvier
Hi Alex, I noticed the new symbols lack QEMU_PLUGIN_API qualifier in include/qemu/qemu-plugin.h: - qemu_plugin_update_ns - qemu_plugin_request_time_control So it would be impossible to use those symbols on windows. I kept a reminder to send a new patch after you pulled this, but if we go to

[PATCH 8/9] plugins: add time control API

2024-06-12 Thread Alex Bennée
Expose the ability to control time through the plugin API. Only one plugin can control time so it has to request control when loaded. There are probably more corner cases to catch here. From: Alex Bennée Signed-off-by: Pierrick Bouvier [AJB: tweaked user-mode handling] Signed-off-by: Alex