Re: [PATCH RESEND v6 0/5] migration: reduce time of loading non-iterable vmstate

2023-03-09 Thread Chuang Xu
Hi, Peter, On 2023/3/8 下午11:46, Peter Xu wrote: 1. squash fix into patch1 of yours. 2. introduce address_space_to_flatview_rcu() 3. add specific comment to define when to use which as_to_flat() This can be together with 2). We should suggest using address_space_to_flatview() by default in the

Re: [PATCH RESEND v6 0/5] migration: reduce time of loading non-iterable vmstate

2023-03-08 Thread Peter Xu
On Wed, Mar 08, 2023 at 11:27:40PM +0800, Chuang Xu wrote: > Hi, Peter, > > On 2023/3/8 下午10:58, Peter Xu wrote: > > On Wed, Mar 08, 2023 at 06:03:45AM -0800, Chuang Xu wrote: > > > IIUC, Do you mean that different ways to get flatview are tricky? > > Yes, and properly define when to use which. >

Re: [PATCH RESEND v6 0/5] migration: reduce time of loading non-iterable vmstate

2023-03-08 Thread Chuang Xu
Hi, Peter, On 2023/3/8 下午10:58, Peter Xu wrote: On Wed, Mar 08, 2023 at 06:03:45AM -0800, Chuang Xu wrote: IIUC, Do you mean that different ways to get flatview are tricky? Yes, and properly define when to use which. As you said, it's slightly beyond what this series does. Maybe it would be

Re: [PATCH RESEND v6 0/5] migration: reduce time of loading non-iterable vmstate

2023-03-08 Thread Peter Xu
On Wed, Mar 08, 2023 at 06:03:45AM -0800, Chuang Xu wrote: > IIUC, Do you mean that different ways to get flatview are tricky? Yes, and properly define when to use which. > As you said, it's slightly beyond what this series does. Maybe it would be > better if we discuss it in a new series and kee

Re: [PATCH RESEND v6 0/5] migration: reduce time of loading non-iterable vmstate

2023-03-08 Thread Chuang Xu
Hi, Peter, On 2023/3/8 上午1:04, Peter Xu wrote: > On Tue, Mar 07, 2023 at 09:24:31PM +0800, Chuang Xu wrote: >>> Why do we need address_space_get_flatview_rcu()? I'm not sure whether you >> address_space_cahce_init() uses address_space_get_flatview() to acquire >> a ref-ed flatview. If we want to u

Re: [PATCH RESEND v6 0/5] migration: reduce time of loading non-iterable vmstate

2023-03-07 Thread Peter Xu
On Tue, Mar 07, 2023 at 09:24:31PM +0800, Chuang Xu wrote: > > Why do we need address_space_get_flatview_rcu()? I'm not sure whether you > > address_space_cahce_init() uses address_space_get_flatview() to acquire > a ref-ed flatview. If we want to use address_space_to_flatview_rcu() and > make th

Re: [PATCH RESEND v6 0/5] migration: reduce time of loading non-iterable vmstate

2023-03-07 Thread Chuang Xu
Hi, Peter, On 2023/3/7 上午4:48, Peter Xu wrote: On Mon, Mar 06, 2023 at 08:48:05PM +0800, Chuang Xu wrote: Hi, Peter, On 2023/3/6 上午6:05, Peter Xu wrote: 1.virtio_load->virtio_init_region_cache 2.virtio_load->virtio_set_features_nocheck What is this one specifically? I failed to see quickly

Re: [PATCH RESEND v6 0/5] migration: reduce time of loading non-iterable vmstate

2023-03-06 Thread Peter Xu
On Mon, Mar 06, 2023 at 08:48:05PM +0800, Chuang Xu wrote: > Hi, Peter, > > On 2023/3/6 上午6:05, Peter Xu wrote: > > Hi, Chuang, > > > > On Fri, Mar 03, 2023 at 06:56:50PM +0800, Chuang Xu wrote: > > > Sorry to forget to update the test results in the last patch of v6. > > > > > > In this version

Re: [PATCH RESEND v6 0/5] migration: reduce time of loading non-iterable vmstate

2023-03-06 Thread Chuang Xu
Hi, Peter, On 2023/3/6 上午6:05, Peter Xu wrote: Hi, Chuang, On Fri, Mar 03, 2023 at 06:56:50PM +0800, Chuang Xu wrote: Sorry to forget to update the test results in the last patch of v6. In this version: - add peter's patch. - split mr_do_commit() from mr_commit(). - adjust the sanity check i

Re: [PATCH RESEND v6 0/5] migration: reduce time of loading non-iterable vmstate

2023-03-05 Thread Peter Xu
Hi, Chuang, On Fri, Mar 03, 2023 at 06:56:50PM +0800, Chuang Xu wrote: > Sorry to forget to update the test results in the last patch of v6. > > In this version: > > - add peter's patch. > - split mr_do_commit() from mr_commit(). > - adjust the sanity check in address_space_to_flatview(). > - re

[PATCH RESEND v6 0/5] migration: reduce time of loading non-iterable vmstate

2023-03-03 Thread Chuang Xu
Sorry to forget to update the test results in the last patch of v6. In this version: - add peter's patch. - split mr_do_commit() from mr_commit(). - adjust the sanity check in address_space_to_flatview(). - rebase to latest upstream. - replace 8260 with 8362 as testing host. - update the lates