Re: [PATCH RFC] migrate/ram: remove "ram_bulk_stage" and "fpo_enabled"

2021-05-11 Thread David Hildenbrand
On 10.05.21 20:58, Dr. David Alan Gilbert wrote: * David Hildenbrand (da...@redhat.com) wrote: The bulk stage is kind of weird: migration_bitmap_find_dirty() will indicate a dirty page, however, ram_save_host_page() will never save it, as migration_bitmap_clear_dirty() detects that it is not

Re: [PATCH RFC] migrate/ram: remove "ram_bulk_stage" and "fpo_enabled"

2021-05-10 Thread Dr. David Alan Gilbert
* David Hildenbrand (da...@redhat.com) wrote: > The bulk stage is kind of weird: migration_bitmap_find_dirty() will > indicate a dirty page, however, ram_save_host_page() will never save it, as > migration_bitmap_clear_dirty() detects that it is not dirty. > > We already fill the bitmap in

Re: [PATCH RFC] migrate/ram: remove "ram_bulk_stage" and "fpo_enabled"

2021-03-05 Thread David Hildenbrand
On 16.02.21 11:50, David Hildenbrand wrote: The bulk stage is kind of weird: migration_bitmap_find_dirty() will indicate a dirty page, however, ram_save_host_page() will never save it, as migration_bitmap_clear_dirty() detects that it is not dirty. We already fill the bitmap in

[PATCH RFC] migrate/ram: remove "ram_bulk_stage" and "fpo_enabled"

2021-02-16 Thread David Hildenbrand
The bulk stage is kind of weird: migration_bitmap_find_dirty() will indicate a dirty page, however, ram_save_host_page() will never save it, as migration_bitmap_clear_dirty() detects that it is not dirty. We already fill the bitmap in ram_list_init_bitmaps() with ones, marking everything dirty -