Re: [PATCH RFC 0/4] memory: Fix (/ Discuss) a few rcu issues

2023-03-03 Thread David Hildenbrand
On 03.03.23 17:20, Peter Xu wrote: On Fri, Mar 03, 2023 at 10:10:12AM +0100, David Hildenbrand wrote: On 02.03.23 22:50, Peter Xu wrote: On Thu, Mar 02, 2023 at 04:11:56PM +0100, David Hildenbrand wrote: I guess the main concern here would be overhead from gabbing/releasing the BQL very often,

Re: [PATCH RFC 0/4] memory: Fix (/ Discuss) a few rcu issues

2023-03-03 Thread Peter Xu
On Fri, Mar 03, 2023 at 10:10:12AM +0100, David Hildenbrand wrote: > On 02.03.23 22:50, Peter Xu wrote: > > On Thu, Mar 02, 2023 at 04:11:56PM +0100, David Hildenbrand wrote: > > > I guess the main concern here would be overhead from gabbing/releasing the > > > BQL very often, and blocking the BQL

Re: [PATCH RFC 0/4] memory: Fix (/ Discuss) a few rcu issues

2023-03-03 Thread David Hildenbrand
On 02.03.23 22:50, Peter Xu wrote: On Thu, Mar 02, 2023 at 04:11:56PM +0100, David Hildenbrand wrote: I guess the main concern here would be overhead from gabbing/releasing the BQL very often, and blocking the BQL while we're eventually in the kernel, clearing bitmaps, correct? More or less ye

Re: [PATCH RFC 0/4] memory: Fix (/ Discuss) a few rcu issues

2023-03-02 Thread Peter Xu
On Thu, Mar 02, 2023 at 04:11:56PM +0100, David Hildenbrand wrote: > I guess the main concern here would be overhead from gabbing/releasing the > BQL very often, and blocking the BQL while we're eventually in the kernel, > clearing bitmaps, correct? More or less yes. I think it's pretty clear we

Re: [PATCH RFC 0/4] memory: Fix (/ Discuss) a few rcu issues

2023-03-02 Thread David Hildenbrand
On 02.03.23 15:45, Peter Xu wrote: On Thu, Mar 02, 2023 at 10:46:56AM +0100, David Hildenbrand wrote: On 25.02.23 17:31, Peter Xu wrote: [not for merging, but for discussion; this is something I found when looking at another issue on Chuang's optimization for migration downtime] Summary: we

Re: [PATCH RFC 0/4] memory: Fix (/ Discuss) a few rcu issues

2023-03-02 Thread Peter Xu
On Thu, Mar 02, 2023 at 09:45:35AM -0500, Peter Xu wrote: > On Thu, Mar 02, 2023 at 10:46:56AM +0100, David Hildenbrand wrote: > > On 25.02.23 17:31, Peter Xu wrote: > > > [not for merging, but for discussion; this is something I found when > > > looking at another issue on Chuang's optimization

Re: [PATCH RFC 0/4] memory: Fix (/ Discuss) a few rcu issues

2023-03-02 Thread Peter Xu
On Thu, Mar 02, 2023 at 10:46:56AM +0100, David Hildenbrand wrote: > On 25.02.23 17:31, Peter Xu wrote: > > [not for merging, but for discussion; this is something I found when > > looking at another issue on Chuang's optimization for migration downtime] > > > > Summary: we tried to access memor

Re: [PATCH RFC 0/4] memory: Fix (/ Discuss) a few rcu issues

2023-03-02 Thread David Hildenbrand
On 25.02.23 17:31, Peter Xu wrote: [not for merging, but for discussion; this is something I found when looking at another issue on Chuang's optimization for migration downtime] Summary: we tried to access memory_listeners, address_spaces, etc. in RCU way. However we didn't implement them wit

Re: [PATCH RFC 0/4] memory: Fix (/ Discuss) a few rcu issues

2023-03-01 Thread Peter Xu
On Tue, Feb 28, 2023 at 07:09:57PM -0500, Stefan Hajnoczi wrote: > On Sat, Feb 25, 2023 at 11:31:37AM -0500, Peter Xu wrote: > > [not for merging, but for discussion; this is something I found when > > looking at another issue on Chuang's optimization for migration downtime] > > > > Summary: we t

Re: [PATCH RFC 0/4] memory: Fix (/ Discuss) a few rcu issues

2023-02-28 Thread Stefan Hajnoczi
On Sat, Feb 25, 2023 at 11:31:37AM -0500, Peter Xu wrote: > [not for merging, but for discussion; this is something I found when > looking at another issue on Chuang's optimization for migration downtime] > > Summary: we tried to access memory_listeners, address_spaces, etc. in RCU > way. Howeve

[PATCH RFC 0/4] memory: Fix (/ Discuss) a few rcu issues

2023-02-25 Thread Peter Xu
[not for merging, but for discussion; this is something I found when looking at another issue on Chuang's optimization for migration downtime] Summary: we tried to access memory_listeners, address_spaces, etc. in RCU way. However we didn't implement them with RCU-safety. This patchset is trying