Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-22 Thread Paolo Bonzini
Il gio 22 giu 2023, 23:18 John Snow ha scritto: > Possibly I could teach mkvenv a new trick, like "mkvenv init iotests" > and have the mkvenv script DTRT at that point, whatever that is -- > ideally exiting very quickly without doing anything. > Or maybe check itself should do the bootstrap if

Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-22 Thread John Snow
On Thu, Jun 22, 2023 at 5:12 PM Paolo Bonzini wrote: > > On Thu, Jun 22, 2023 at 11:08 PM John Snow wrote: > > > > On Thu, Jun 22, 2023 at 5:05 PM Paolo Bonzini wrote: > > > > > > On Thu, Jun 22, 2023 at 11:03 PM John Snow wrote: > > > > If we always install it in editable mode, and the path

Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-22 Thread Paolo Bonzini
On Thu, Jun 22, 2023 at 11:08 PM John Snow wrote: > > On Thu, Jun 22, 2023 at 5:05 PM Paolo Bonzini wrote: > > > > On Thu, Jun 22, 2023 at 11:03 PM John Snow wrote: > > > If we always install it in editable mode, and the path where it is > > > "installed" is what we expect it to be, it

Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-22 Thread John Snow
On Thu, Jun 22, 2023 at 5:05 PM Paolo Bonzini wrote: > > On Thu, Jun 22, 2023 at 11:03 PM John Snow wrote: > > If we always install it in editable mode, and the path where it is > > "installed" is what we expect it to be, it shouldn't have any problems > > with being out of date I think. We

Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-22 Thread Paolo Bonzini
On Thu, Jun 22, 2023 at 11:03 PM John Snow wrote: > If we always install it in editable mode, and the path where it is > "installed" is what we expect it to be, it shouldn't have any problems > with being out of date I think. We could conceivably use the > "faux" package version the internal

Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-22 Thread John Snow
On Thu, Jun 22, 2023 at 5:24 AM Paolo Bonzini wrote: > > On Wed, Jun 21, 2023 at 9:08 AM Paolo Bonzini wrote: > > Maybe patch 4 can use distlib.scripts as well to create the check script in > > the build directory? (Yes that's another mkvenv functionality...) On a > > phone and don't have the

Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-22 Thread Paolo Bonzini
On Wed, Jun 21, 2023 at 9:08 AM Paolo Bonzini wrote: > Maybe patch 4 can use distlib.scripts as well to create the check script in > the build directory? (Yes that's another mkvenv functionality...) On a phone > and don't have the docs at hand, so I am not sure. If not, your solution is > good

Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-21 Thread Paolo Bonzini
Il mer 21 giu 2023, 02:21 John Snow ha scritto: > Hi, this is ... a fairly incomplete series about trying to get iotests > to run out of the configure-time venv. I'm looking for some feedback, so > out to the list it goes. > > Primarily, I'm having doubts about these points: > > 1) I think I

[PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-20 Thread John Snow
Hi, this is ... a fairly incomplete series about trying to get iotests to run out of the configure-time venv. I'm looking for some feedback, so out to the list it goes. Primarily, I'm having doubts about these points: 1) I think I need something like "mkvenv install" in the first patch, but