Re: [PATCH V1 07/26] migration: VMStateId

2024-05-30 Thread Peter Xu
On Thu, May 30, 2024 at 01:11:26PM -0400, Steven Sistare wrote: > On 5/29/2024 2:53 PM, Peter Xu wrote: > > On Wed, May 29, 2024 at 01:30:18PM -0400, Steven Sistare wrote: > > > How about a more general name for the type: > > > > > > migration/misc.h > > > typedef char (MigrationId)[256]; >

Re: [PATCH V1 07/26] migration: VMStateId

2024-05-30 Thread Steven Sistare via
On 5/29/2024 2:53 PM, Peter Xu wrote: On Wed, May 29, 2024 at 01:30:18PM -0400, Steven Sistare wrote: How about a more general name for the type: migration/misc.h typedef char (MigrationId)[256]; How about qemu/typedefs.h? Not sure whether it's applicable. Markus (in the loop) may have

Re: [PATCH V1 07/26] migration: VMStateId

2024-05-29 Thread Peter Xu
On Wed, May 29, 2024 at 01:30:18PM -0400, Steven Sistare wrote: > How about a more general name for the type: > > migration/misc.h > typedef char (MigrationId)[256]; How about qemu/typedefs.h? Not sure whether it's applicable. Markus (in the loop) may have a better idea. Meanwhile,

Re: [PATCH V1 07/26] migration: VMStateId

2024-05-29 Thread Steven Sistare via
On 5/28/2024 1:44 PM, Peter Xu wrote: On Tue, May 28, 2024 at 11:10:03AM -0400, Steven Sistare via wrote: On 5/27/2024 2:20 PM, Peter Xu wrote: On Mon, Apr 29, 2024 at 08:55:16AM -0700, Steve Sistare wrote: Define a type for the 256 byte id string to guarantee the same length is used and

Re: [PATCH V1 07/26] migration: VMStateId

2024-05-28 Thread Peter Xu
On Tue, May 28, 2024 at 11:10:03AM -0400, Steven Sistare via wrote: > On 5/27/2024 2:20 PM, Peter Xu wrote: > > On Mon, Apr 29, 2024 at 08:55:16AM -0700, Steve Sistare wrote: > > > Define a type for the 256 byte id string to guarantee the same length is > > > used and enforced everywhere. > > > >

Re: [PATCH V1 07/26] migration: VMStateId

2024-05-28 Thread Steven Sistare via
On 5/27/2024 2:20 PM, Peter Xu wrote: On Mon, Apr 29, 2024 at 08:55:16AM -0700, Steve Sistare wrote: Define a type for the 256 byte id string to guarantee the same length is used and enforced everywhere. Signed-off-by: Steve Sistare --- include/exec/ramblock.h | 3 ++-

Re: [PATCH V1 07/26] migration: VMStateId

2024-05-27 Thread Peter Xu
On Mon, Apr 29, 2024 at 08:55:16AM -0700, Steve Sistare wrote: > Define a type for the 256 byte id string to guarantee the same length is > used and enforced everywhere. > > Signed-off-by: Steve Sistare > --- > include/exec/ramblock.h | 3 ++- > include/migration/vmstate.h | 2 ++ >

Re: [PATCH V1 07/26] migration: VMStateId

2024-05-07 Thread Fabiano Rosas
Steve Sistare writes: > Define a type for the 256 byte id string to guarantee the same length is > used and enforced everywhere. > > Signed-off-by: Steve Sistare Reviewed-by: Fabiano Rosas

[PATCH V1 07/26] migration: VMStateId

2024-04-29 Thread Steve Sistare
Define a type for the 256 byte id string to guarantee the same length is used and enforced everywhere. Signed-off-by: Steve Sistare --- include/exec/ramblock.h | 3 ++- include/migration/vmstate.h | 2 ++ migration/savevm.c | 8 migration/vmstate.c | 3 ++- 4 files