Re: [PATCH V1 1/4] migration: mode parameter

2023-10-20 Thread Steven Sistare
Hi Daniel, does the addition of MigMode in qdev below look OK to you? It exactly mirrors qdev_prop_blockdev_on_error + DEFINE_PROP_BLOCKDEV_ON_ERROR. I realize I need to add: QEMU_BUILD_BUG_ON(sizeof(MigMode) != sizeof(int)); and I need to delete "exec" from the .description. I will cc you wh

Re: [PATCH V1 1/4] migration: mode parameter

2023-10-20 Thread Juan Quintela
Steven Sistare wrote: > On 10/20/2023 5:29 AM, Juan Quintela wrote: >> Steve Sistare wrote: >>> Create a mode migration parameter that can be used to select alternate >>> migration algorithms. The default mode is normal, representing the >>> current migration algorithm, and does not need to be e

Re: [PATCH V1 1/4] migration: mode parameter

2023-10-20 Thread Steven Sistare
On 10/20/2023 5:29 AM, Juan Quintela wrote: > Steve Sistare wrote: >> Create a mode migration parameter that can be used to select alternate >> migration algorithms. The default mode is normal, representing the >> current migration algorithm, and does not need to be explicitly set. >> >> No funct

Re: [PATCH V1 1/4] migration: mode parameter

2023-10-20 Thread Juan Quintela
Steve Sistare wrote: > Create a mode migration parameter that can be used to select alternate > migration algorithms. The default mode is normal, representing the > current migration algorithm, and does not need to be explicitly set. > > No functional change until a new mode is added, except that

[PATCH V1 1/4] migration: mode parameter

2023-10-19 Thread Steve Sistare
Create a mode migration parameter that can be used to select alternate migration algorithms. The default mode is normal, representing the current migration algorithm, and does not need to be explicitly set. No functional change until a new mode is added, except that the mode is shown by the 'info