Re: [PATCH V1 24/32] ui: save/restore vnc socket fds

2020-07-31 Thread Steven Sistare
On 7/31/2020 5:06 AM, Daniel P. Berrangé wrote: > On Thu, Jul 30, 2020 at 08:14:28AM -0700, Steve Sistare wrote: >> From: Mark Kanda >> >> Iterate through the VNC displays and save/restore the socket fds. > > This patch doesn't appear to do anything around the client state, so I > can't see how t

Re: [PATCH V1 24/32] ui: save/restore vnc socket fds

2020-07-31 Thread Daniel P . Berrangé
On Thu, Jul 30, 2020 at 08:14:28AM -0700, Steve Sistare wrote: > From: Mark Kanda > > Iterate through the VNC displays and save/restore the socket fds. This patch doesn't appear to do anything around the client state, so I can't see how this will work in general. eg QEMU is 1/2 way through rece

[PATCH V1 24/32] ui: save/restore vnc socket fds

2020-07-30 Thread Steve Sistare
From: Mark Kanda Iterate through the VNC displays and save/restore the socket fds. Signed-off-by: Mark Kanda Signed-off-by: Steve Sistare --- include/sysemu/sysemu.h | 2 + migration/savevm.c | 3 + ui/vnc.c| 153 +++- 3 fil