Re: [PATCH V10 2/8] target/mips: Fix PageMask with variable page size

2020-09-22 Thread Huacai Chen
Hi Carlo, On Tue, Sep 22, 2020 at 4:00 PM Carlo Arenas wrote: > > On Mon, Sep 21, 2020 at 7:53 PM Huacai Chen wrote: > > was just added to mips target and that's nolonger true. > s/nolonger/no longer/ > > IMHO might be worth also mentioning that it was added with ee3863b9d4 > (target/mips:

Re: [PATCH V10 2/8] target/mips: Fix PageMask with variable page size

2020-09-22 Thread Carlo Arenas
On Mon, Sep 21, 2020 at 7:53 PM Huacai Chen wrote: > was just added to mips target and that's nolonger true. s/nolonger/no longer/ IMHO might be worth also mentioning that it was added with ee3863b9d4 (target/mips: Support variable page size, 2020-04-08) to give a little more context. some

[PATCH V10 2/8] target/mips: Fix PageMask with variable page size

2020-09-21 Thread Huacai Chen
From: Jiaxun Yang Our current code assumed the target page size is always 4k when handling PageMask and VPN2, however, variable page size was just added to mips target and that's nolonger true. Signed-off-by: Huacai Chen Signed-off-by: Jiaxun Yang --- target/mips/cp0_helper.c | 36