Re: [PATCH V2 3/4] intel-iommu: convert VTD_PE_GET_FPD_ERR() to be a function

2022-04-22 Thread Peter Xu
On Mon, Mar 21, 2022 at 01:54:28PM +0800, Jason Wang wrote: > We used to have a macro for VTD_PE_GET_FPD_ERR() but it has an > internal goto which prevents it from being reused. This patch convert > that macro to a dedicated function and let the caller to decide what > to do (e.g using goto or

Re: [PATCH V2 3/4] intel-iommu: convert VTD_PE_GET_FPD_ERR() to be a function

2022-03-27 Thread Jason Wang
On Thu, Mar 24, 2022 at 4:27 PM Tian, Kevin wrote: > > > From: Jason Wang > > Sent: Monday, March 21, 2022 1:54 PM > > @@ -1724,6 +1713,19 @@ out: > > trace_vtd_pt_enable_fast_path(source_id, success); > > } > > > > +static void vtd_qualify_report_fault(IntelIOMMUState *s, > > +

RE: [PATCH V2 3/4] intel-iommu: convert VTD_PE_GET_FPD_ERR() to be a function

2022-03-24 Thread Tian, Kevin
> From: Jason Wang > Sent: Monday, March 21, 2022 1:54 PM > @@ -1724,6 +1713,19 @@ out: > trace_vtd_pt_enable_fast_path(source_id, success); > } > > +static void vtd_qualify_report_fault(IntelIOMMUState *s, > + int err, bool is_fpd_set, > +

[PATCH V2 3/4] intel-iommu: convert VTD_PE_GET_FPD_ERR() to be a function

2022-03-20 Thread Jason Wang
We used to have a macro for VTD_PE_GET_FPD_ERR() but it has an internal goto which prevents it from being reused. This patch convert that macro to a dedicated function and let the caller to decide what to do (e.g using goto or not). This makes sure it can be re-used for other function that