Re: [PATCH V4 1/5] util: strList_from_string

2024-02-22 Thread Steven Sistare
On 2/21/2024 12:01 PM, Steven Sistare wrote: > On 2/21/2024 8:29 AM, Markus Armbruster wrote: >> I apologize for the lateness of my review. > > No problem. Thanks for the review. > >> Steve Sistare writes: >> >>> Generalize hmp_split_at_comma() to take any delimiter string, rename >>> as strLis

Re: [PATCH V4 1/5] util: strList_from_string

2024-02-21 Thread Steven Sistare
On 2/21/2024 8:29 AM, Markus Armbruster wrote: > I apologize for the lateness of my review. No problem. Thanks for the review. > Steve Sistare writes: > >> Generalize hmp_split_at_comma() to take any delimiter string, rename >> as strList_from_string(), and move it to util/strList.c. >> >> No

Re: [PATCH V4 1/5] util: strList_from_string

2024-02-21 Thread Markus Armbruster
I apologize for the lateness of my review. Steve Sistare writes: > Generalize hmp_split_at_comma() to take any delimiter string, rename > as strList_from_string(), and move it to util/strList.c. > > No functional change. > > Signed-off-by: Steve Sistare I can't see an actual use of generalized

[PATCH V4 1/5] util: strList_from_string

2024-01-12 Thread Steve Sistare
Generalize hmp_split_at_comma() to take any delimiter string, rename as strList_from_string(), and move it to util/strList.c. No functional change. Signed-off-by: Steve Sistare --- include/monitor/hmp.h | 1 - include/qemu/strList.h | 24 monitor/hmp-cmds.c | 19 -