Re: [PATCH V4 5/6] block/rbd: add write zeroes support

2021-07-02 Thread Ilya Dryomov
On Fri, Jul 2, 2021 at 11:09 AM Peter Lieven wrote: > > this patch wittingly sets BDRV_REQ_NO_FALLBACK and silently ignores > BDRV_REQ_MAY_UNMAP > for older librbd versions. > > The rationale for this is as following (citing Ilya Dryomov current RBD > maintainer): > ---8<--- > a) remove the BDRV

[PATCH V4 5/6] block/rbd: add write zeroes support

2021-07-02 Thread Peter Lieven
this patch wittingly sets BDRV_REQ_NO_FALLBACK and silently ignores BDRV_REQ_MAY_UNMAP for older librbd versions. The rationale for this is as following (citing Ilya Dryomov current RBD maintainer): ---8<--- a) remove the BDRV_REQ_MAY_UNMAP check in qemu_rbd_co_pwrite_zeroes() and as a conseq