Re: [PATCH V6 03/14] cpus: stop vm in suspended runstate

2024-01-07 Thread Markus Armbruster
Steven Sistare writes: [...] > With these changes, can I add your Acked-by to the commit? I'm afraid I lost context over the break. Suggest you post v7, and I provide my Acked-by there. Likely easier for me. Happy new year! [...]

Re: [PATCH V6 03/14] cpus: stop vm in suspended runstate

2024-01-03 Thread Steven Sistare
On 12/23/2023 12:41 AM, Markus Armbruster wrote: > Steven Sistare writes: > >> On 12/22/2023 7:20 AM, Markus Armbruster wrote: >>> Steve Sistare writes: >>> Currently, a vm in the suspended state is not completely stopped. The VCPUs have been paused, but the cpu clock still runs

Re: [PATCH V6 03/14] cpus: stop vm in suspended runstate

2024-01-03 Thread Steven Sistare
On 1/3/2024 8:09 AM, Peter Xu wrote: > Steven, > > The discussions seem to still apply to the latest. Do you plan to post a > new version, with everything covered? Yes, today, thanks - steve

Re: [PATCH V6 03/14] cpus: stop vm in suspended runstate

2024-01-03 Thread Peter Xu
Steven, The discussions seem to still apply to the latest. Do you plan to post a new version, with everything covered? Thanks, -- Peter Xu

Re: [PATCH V6 03/14] cpus: stop vm in suspended runstate

2023-12-22 Thread Markus Armbruster
Steven Sistare writes: > On 12/22/2023 7:20 AM, Markus Armbruster wrote: >> Steve Sistare writes: >> >>> Currently, a vm in the suspended state is not completely stopped. The VCPUs >>> have been paused, but the cpu clock still runs, and runstate notifiers for >>> the transition to stopped have

Re: [PATCH V6 03/14] cpus: stop vm in suspended runstate

2023-12-22 Thread Steven Sistare
On 12/22/2023 7:20 AM, Markus Armbruster wrote: > Steve Sistare writes: > >> Currently, a vm in the suspended state is not completely stopped. The VCPUs >> have been paused, but the cpu clock still runs, and runstate notifiers for >> the transition to stopped have not been called. This causes p

Re: [PATCH V6 03/14] cpus: stop vm in suspended runstate

2023-12-22 Thread Markus Armbruster
Steve Sistare writes: > Currently, a vm in the suspended state is not completely stopped. The VCPUs > have been paused, but the cpu clock still runs, and runstate notifiers for > the transition to stopped have not been called. This causes problems for > live migration. Stale cpu timers_state i

Re: [PATCH V6 03/14] cpus: stop vm in suspended runstate

2023-12-04 Thread Steven Sistare
On 12/4/2023 11:35 AM, Peter Xu wrote: > On Fri, Dec 01, 2023 at 12:11:32PM -0500, Steven Sistare wrote: diff --git a/include/sysemu/runstate.h b/include/sysemu/runstate.h index f6a337b..1d6828f 100644 --- a/include/sysemu/runstate.h +++ b/include/sysemu/runstate.h @@ -40,6

Re: [PATCH V6 03/14] cpus: stop vm in suspended runstate

2023-12-04 Thread Peter Xu
On Fri, Dec 01, 2023 at 12:11:32PM -0500, Steven Sistare wrote: > >> diff --git a/include/sysemu/runstate.h b/include/sysemu/runstate.h > >> index f6a337b..1d6828f 100644 > >> --- a/include/sysemu/runstate.h > >> +++ b/include/sysemu/runstate.h > >> @@ -40,6 +40,11 @@ static inline bool > >> shutd

Re: [PATCH V6 03/14] cpus: stop vm in suspended runstate

2023-12-01 Thread Steven Sistare
On 11/30/2023 5:10 PM, Peter Xu wrote: > On Thu, Nov 30, 2023 at 01:37:16PM -0800, Steve Sistare wrote: >> Currently, a vm in the suspended state is not completely stopped. The VCPUs >> have been paused, but the cpu clock still runs, and runstate notifiers for >> the transition to stopped have not

Re: [PATCH V6 03/14] cpus: stop vm in suspended runstate

2023-11-30 Thread Peter Xu
On Thu, Nov 30, 2023 at 01:37:16PM -0800, Steve Sistare wrote: > Currently, a vm in the suspended state is not completely stopped. The VCPUs > have been paused, but the cpu clock still runs, and runstate notifiers for > the transition to stopped have not been called. This causes problems for > li

[PATCH V6 03/14] cpus: stop vm in suspended runstate

2023-11-30 Thread Steve Sistare
Currently, a vm in the suspended state is not completely stopped. The VCPUs have been paused, but the cpu clock still runs, and runstate notifiers for the transition to stopped have not been called. This causes problems for live migration. Stale cpu timers_state is saved to the migration stream,