Re: [PATCH V8 02/39] migration: qemu file wrappers

2022-07-05 Thread Steven Sistare
On 6/16/2022 11:29 AM, Daniel P. Berrangé wrote: > On Wed, Jun 15, 2022 at 07:51:49AM -0700, Steve Sistare wrote: >> Add qemu_file_open and qemu_fd_open to create QEMUFile objects for unix >> files and file descriptors. >> >> Signed-off-by: Steve Sistare >> --- >> migration/qemu-file-channel.c |

Re: [PATCH V8 02/39] migration: qemu file wrappers

2022-07-05 Thread Steven Sistare
On 6/16/2022 10:55 AM, Marc-André Lureau wrote: > Hi > > On Wed, Jun 15, 2022 at 6:54 PM Steve Sistare > wrote: > > Add qemu_file_open and qemu_fd_open to create QEMUFile objects for unix > files and file descriptors. > > File descriptors are not really

Re: [PATCH V8 02/39] migration: qemu file wrappers

2022-07-05 Thread Steven Sistare
On 6/15/2022 10:18 PM, Guoyi Tu wrote: > On 2022/6/15 22:51, Steve Sistare wrote: >> Add qemu_file_open and qemu_fd_open to create QEMUFile objects for unix >> files and file descriptors. >> > the function names should be updated. > > -- > Guoyi Yes indeed, thanks - Steve >> Signed-off-by: Stev

Re: [PATCH V8 02/39] migration: qemu file wrappers

2022-06-16 Thread Daniel P . Berrangé
On Wed, Jun 15, 2022 at 07:51:49AM -0700, Steve Sistare wrote: > Add qemu_file_open and qemu_fd_open to create QEMUFile objects for unix > files and file descriptors. > > Signed-off-by: Steve Sistare > --- > migration/qemu-file-channel.c | 36 > migration/qem

Re: [PATCH V8 02/39] migration: qemu file wrappers

2022-06-16 Thread Marc-André Lureau
Hi On Wed, Jun 15, 2022 at 6:54 PM Steve Sistare wrote: > Add qemu_file_open and qemu_fd_open to create QEMUFile objects for unix > files and file descriptors. > File descriptors are not really unix specific, but that's a detail. The names of the functions in the summary do not match the code,

Re: [PATCH V8 02/39] migration: qemu file wrappers

2022-06-15 Thread Guoyi Tu
On 2022/6/15 22:51, Steve Sistare wrote: Add qemu_file_open and qemu_fd_open to create QEMUFile objects for unix files and file descriptors. the function names should be updated. -- Guoyi Signed-off-by: Steve Sistare --- migration/qemu-file-channel.c | 36 ++

[PATCH V8 02/39] migration: qemu file wrappers

2022-06-15 Thread Steve Sistare
Add qemu_file_open and qemu_fd_open to create QEMUFile objects for unix files and file descriptors. Signed-off-by: Steve Sistare --- migration/qemu-file-channel.c | 36 migration/qemu-file-channel.h | 6 ++ 2 files changed, 42 insertions(+) diff --git a