Re: [PATCH ats_vtd v5 01/22] intel_iommu: fix FRCD construction macro.

2024-07-02 Thread CLEMENT MATHIEU--DRIF
On 02/07/2024 15:01, Yi Liu wrote: > Caution: External email. Do not open attachments or click links, > unless this email comes from a known sender and you know the content > is safe. > > > On 2024/7/2 13:52, CLEMENT MATHIEU--DRIF wrote: >> From: Clément Mathieu--Drif >> >> The constant must be

Re: [PATCH ats_vtd v5 01/22] intel_iommu: fix FRCD construction macro.

2024-07-02 Thread Yi Liu
On 2024/7/2 13:52, CLEMENT MATHIEU--DRIF wrote: From: Clément Mathieu--Drif The constant must be unsigned, otherwise the two's complement overrides the other fields when a PASID is present does it need a fix tag since it overrides the other fields? Reviewed-by: Yi Liu Signed-off-by: Cléme

[PATCH ats_vtd v5 01/22] intel_iommu: fix FRCD construction macro.

2024-07-01 Thread CLEMENT MATHIEU--DRIF
From: Clément Mathieu--Drif The constant must be unsigned, otherwise the two's complement overrides the other fields when a PASID is present Signed-off-by: Clément Mathieu--Drif --- hw/i386/intel_iommu_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/intel

[PATCH ats_vtd v5 01/22] intel_iommu: fix FRCD construction macro.

2024-06-02 Thread CLEMENT MATHIEU--DRIF
From: Clément Mathieu--Drif The constant must be unsigned, otherwise the two's complement overrides the other fields when a PASID is present Signed-off-by: Clément Mathieu--Drif --- hw/i386/intel_iommu_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/intel