Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2020-01-09 Thread Auger Eric
Hi Jean, On 1/9/20 12:15 PM, Jean-Philippe Brucker wrote: > On Thu, Jan 09, 2020 at 12:01:26PM +0100, Auger Eric wrote: >> Hi, >> >> On 1/9/20 11:40 AM, Jean-Philippe Brucker wrote: >>> On Thu, Jan 09, 2020 at 09:58:49AM +0100, Auger Eric wrote: >> I share Peter's concern about having a differ

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2020-01-09 Thread Jean-Philippe Brucker
On Thu, Jan 09, 2020 at 12:01:26PM +0100, Auger Eric wrote: > Hi, > > On 1/9/20 11:40 AM, Jean-Philippe Brucker wrote: > > On Thu, Jan 09, 2020 at 09:58:49AM +0100, Auger Eric wrote: > I share Peter's concern about having a different default policy than x86. > >>> > >>> Yes I'd say just align

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2020-01-09 Thread Auger Eric
Hi, On 1/9/20 11:40 AM, Jean-Philippe Brucker wrote: > On Thu, Jan 09, 2020 at 09:58:49AM +0100, Auger Eric wrote: I share Peter's concern about having a different default policy than x86. >>> >>> Yes I'd say just align with whatever policy is already in place. Do you >>> think we could add a

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2020-01-09 Thread Jean-Philippe Brucker
On Thu, Jan 09, 2020 at 09:58:49AM +0100, Auger Eric wrote: > >> I share Peter's concern about having a different default policy than x86. > > > > Yes I'd say just align with whatever policy is already in place. Do you > > think we could add a command-line option to let people disable > > default-

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2020-01-09 Thread Auger Eric
Hi Jean, On 1/9/20 9:47 AM, Jean-Philippe Brucker wrote: > On Wed, Jan 08, 2020 at 05:55:52PM +0100, Auger Eric wrote: >> Hi Jean-Philippe, Peter, >> >> On 1/7/20 11:10 AM, Jean-Philippe Brucker wrote: >>> On Mon, Jan 06, 2020 at 12:58:50PM -0500, Peter Xu wrote: On Mon, Jan 06, 2020 at 06:06

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2020-01-09 Thread Jean-Philippe Brucker
On Wed, Jan 08, 2020 at 05:55:52PM +0100, Auger Eric wrote: > Hi Jean-Philippe, Peter, > > On 1/7/20 11:10 AM, Jean-Philippe Brucker wrote: > > On Mon, Jan 06, 2020 at 12:58:50PM -0500, Peter Xu wrote: > >> On Mon, Jan 06, 2020 at 06:06:34PM +0100, Jean-Philippe Brucker wrote: > >>> On Fri, Dec 20

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2020-01-08 Thread Auger Eric
Hi Jean-Philippe, Peter, On 1/7/20 11:10 AM, Jean-Philippe Brucker wrote: > On Mon, Jan 06, 2020 at 12:58:50PM -0500, Peter Xu wrote: >> On Mon, Jan 06, 2020 at 06:06:34PM +0100, Jean-Philippe Brucker wrote: >>> On Fri, Dec 20, 2019 at 11:51:00AM -0500, Peter Xu wrote: On Fri, Dec 20, 2019 at

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2020-01-07 Thread Jean-Philippe Brucker
On Mon, Jan 06, 2020 at 12:58:50PM -0500, Peter Xu wrote: > On Mon, Jan 06, 2020 at 06:06:34PM +0100, Jean-Philippe Brucker wrote: > > On Fri, Dec 20, 2019 at 11:51:00AM -0500, Peter Xu wrote: > > > On Fri, Dec 20, 2019 at 05:26:42PM +0100, Jean-Philippe Brucker wrote: > > > > There is at the virti

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2020-01-06 Thread Peter Xu
On Mon, Jan 06, 2020 at 06:06:34PM +0100, Jean-Philippe Brucker wrote: > On Fri, Dec 20, 2019 at 11:51:00AM -0500, Peter Xu wrote: > > On Fri, Dec 20, 2019 at 05:26:42PM +0100, Jean-Philippe Brucker wrote: > > > There is at the virtio transport level: the driver sets status to > > > FEATURES_OK onc

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2020-01-06 Thread Jean-Philippe Brucker
On Fri, Dec 20, 2019 at 11:51:00AM -0500, Peter Xu wrote: > On Fri, Dec 20, 2019 at 05:26:42PM +0100, Jean-Philippe Brucker wrote: > > There is at the virtio transport level: the driver sets status to > > FEATURES_OK once it accepted the feature bits, and to DRIVER_OK once its > > fully operational

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2019-12-20 Thread Peter Xu
On Fri, Dec 20, 2019 at 05:26:42PM +0100, Jean-Philippe Brucker wrote: > There is at the virtio transport level: the driver sets status to > FEATURES_OK once it accepted the feature bits, and to DRIVER_OK once its > fully operational. The virtio-iommu spec says: > > If the driver does not accept

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2019-12-20 Thread Jean-Philippe Brucker
On Thu, Dec 19, 2019 at 04:09:47PM +0100, Auger Eric wrote: > >> @@ -412,19 +412,80 @@ static IOMMUTLBEntry > >> virtio_iommu_translate(IOMMUMemoryRegion *mr, hwaddr addr, > >> int iommu_idx) > >> { > >> IOMMUDevice *sdev = con

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2019-12-19 Thread Auger Eric
Hi Peter, jean, On 12/19/19 3:49 PM, Peter Xu wrote: > On Thu, Dec 19, 2019 at 03:38:34PM +0100, Auger Eric wrote: >> Hi Peter, >> >> On 12/19/19 2:33 PM, Peter Xu wrote: >>> On Thu, Dec 19, 2019 at 11:30:40AM +0100, Auger Eric wrote: Hi Peter, On 12/10/19 8:33 PM, Peter Xu wrote: >

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2019-12-19 Thread Peter Xu
On Thu, Dec 19, 2019 at 03:38:34PM +0100, Auger Eric wrote: > Hi Peter, > > On 12/19/19 2:33 PM, Peter Xu wrote: > > On Thu, Dec 19, 2019 at 11:30:40AM +0100, Auger Eric wrote: > >> Hi Peter, > >> On 12/10/19 8:33 PM, Peter Xu wrote: > >>> On Fri, Nov 22, 2019 at 07:29:31PM +0100, Eric Auger wrote

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2019-12-19 Thread Auger Eric
Hi Peter, On 12/19/19 2:33 PM, Peter Xu wrote: > On Thu, Dec 19, 2019 at 11:30:40AM +0100, Auger Eric wrote: >> Hi Peter, >> On 12/10/19 8:33 PM, Peter Xu wrote: >>> On Fri, Nov 22, 2019 at 07:29:31PM +0100, Eric Auger wrote: This patch implements the translate callback Signed-off-b

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2019-12-19 Thread Peter Xu
On Thu, Dec 19, 2019 at 11:30:40AM +0100, Auger Eric wrote: > Hi Peter, > On 12/10/19 8:33 PM, Peter Xu wrote: > > On Fri, Nov 22, 2019 at 07:29:31PM +0100, Eric Auger wrote: > >> This patch implements the translate callback > >> > >> Signed-off-by: Eric Auger > >> > >> --- > >> > >> v10 -> v11: >

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2019-12-19 Thread Auger Eric
Hi Peter, On 12/10/19 8:33 PM, Peter Xu wrote: > On Fri, Nov 22, 2019 at 07:29:31PM +0100, Eric Auger wrote: >> This patch implements the translate callback >> >> Signed-off-by: Eric Auger >> >> --- >> >> v10 -> v11: >> - take into account the new value struct and use >> g_tree_lookup_extended >

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2019-12-10 Thread Peter Xu
On Fri, Nov 22, 2019 at 07:29:31PM +0100, Eric Auger wrote: > This patch implements the translate callback > > Signed-off-by: Eric Auger > > --- > > v10 -> v11: > - take into account the new value struct and use > g_tree_lookup_extended > - switched to error_report_once > > v6 -> v7: > - imp

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2019-12-10 Thread Jean-Philippe Brucker
On Fri, Nov 22, 2019 at 07:29:31PM +0100, Eric Auger wrote: > This patch implements the translate callback > > Signed-off-by: Eric Auger Reviewed-by: Jean-Philippe Brucker

[PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2019-11-22 Thread Eric Auger
This patch implements the translate callback Signed-off-by: Eric Auger --- v10 -> v11: - take into account the new value struct and use g_tree_lookup_extended - switched to error_report_once v6 -> v7: - implemented bypass-mode v5 -> v6: - replace error_report by qemu_log_mask v4 -> v5: - c