Re: [PATCH for-5.1 1/8] tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt()

2020-04-15 Thread Markus Armbruster
Kevin Wolf writes: > Am 14.04.2020 um 22:13 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 14.04.2020 um 15:36 hat Markus Armbruster geschrieben: >> >> Kevin Wolf writes: >> >> > Am 14.04.2020 um 11:10 hat Markus Armbruster geschrieben: >> >> >> Eric Blake writes: >> >> >

Re: [PATCH for-5.1 1/8] tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt()

2020-04-15 Thread Kevin Wolf
Am 14.04.2020 um 22:13 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 14.04.2020 um 15:36 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > Am 14.04.2020 um 11:10 hat Markus Armbruster geschrieben: > >> >> Eric Blake writes: > >> >> > On 4/9/20 10:30 AM, Markus

Re: [PATCH for-5.1 1/8] tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt()

2020-04-14 Thread Markus Armbruster
Kevin Wolf writes: > Am 14.04.2020 um 15:36 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> > Am 14.04.2020 um 11:10 hat Markus Armbruster geschrieben: >> >> Eric Blake writes: >> >> > On 4/9/20 10:30 AM, Markus Armbruster wrote: >> >> >> +{ "helpme", false, false, false },

Re: [PATCH for-5.1 1/8] tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt()

2020-04-14 Thread Markus Armbruster
Kevin Wolf writes: > Am 14.04.2020 um 11:10 hat Markus Armbruster geschrieben: >> Eric Blake writes: >> >> > On 4/9/20 10:30 AM, Markus Armbruster wrote: >> >> The two turn out to be inconsistent for "a,b,,help". Test case >> >> marked /* BUG */. >> >> >> >> Signed-off-by: Markus Armbruster >

Re: [PATCH for-5.1 1/8] tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt()

2020-04-14 Thread Kevin Wolf
Am 14.04.2020 um 15:36 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > Am 14.04.2020 um 11:10 hat Markus Armbruster geschrieben: > >> Eric Blake writes: > >> > On 4/9/20 10:30 AM, Markus Armbruster wrote: > >> >> +{ "helpme", false, false, false }, > >> >> +{ "a,help",

Re: [PATCH for-5.1 1/8] tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt()

2020-04-14 Thread Kevin Wolf
Am 14.04.2020 um 11:10 hat Markus Armbruster geschrieben: > Eric Blake writes: > > > On 4/9/20 10:30 AM, Markus Armbruster wrote: > >> The two turn out to be inconsistent for "a,b,,help". Test case > >> marked /* BUG */. > >> > >> Signed-off-by: Markus Armbruster > >> --- > >> tests/test-qemu

Re: [PATCH for-5.1 1/8] tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt()

2020-04-14 Thread Markus Armbruster
Eric Blake writes: > On 4/9/20 10:30 AM, Markus Armbruster wrote: >> The two turn out to be inconsistent for "a,b,,help". Test case >> marked /* BUG */. >> >> Signed-off-by: Markus Armbruster >> --- >> tests/test-qemu-opts.c | 38 ++ >> 1 file changed, 38

Re: [PATCH for-5.1 1/8] tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt()

2020-04-09 Thread Eric Blake
On 4/9/20 10:30 AM, Markus Armbruster wrote: The two turn out to be inconsistent for "a,b,,help". Test case marked /* BUG */. Signed-off-by: Markus Armbruster --- tests/test-qemu-opts.c | 38 ++ 1 file changed, 38 insertions(+) +static void test_has_h

[PATCH for-5.1 1/8] tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt()

2020-04-09 Thread Markus Armbruster
The two turn out to be inconsistent for "a,b,,help". Test case marked /* BUG */. Signed-off-by: Markus Armbruster --- tests/test-qemu-opts.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/tests/test-qemu-opts.c b/tests/test-qemu-opts.c index ef96e84a