Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-30 Thread Philippe Mathieu-Daudé
On 11/16/20 2:10 PM, Roman Bolshakov wrote: > There's a problem for management applications to determine if certain > accelerators available. Generic QMP command should help with that. > > Signed-off-by: Roman Bolshakov > --- > monitor/qmp-cmds.c | 15 +++ > qapi/machine.json | 19 +

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-19 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, Nov 18, 2020 at 09:56:28AM -0600, Eric Blake wrote: >> On 11/18/20 9:45 AM, Eduardo Habkost wrote: >> > On Wed, Nov 18, 2020 at 02:53:26PM +0100, Markus Armbruster wrote: >> > [...] >> >> Another way to skin this cat: >> >> >> >> {"available": {"kvm": { ext

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-18 Thread Eduardo Habkost
On Wed, Nov 18, 2020 at 09:56:28AM -0600, Eric Blake wrote: > On 11/18/20 9:45 AM, Eduardo Habkost wrote: > > On Wed, Nov 18, 2020 at 02:53:26PM +0100, Markus Armbruster wrote: > > [...] > >> Another way to skin this cat: > >> > >> {"available": {"kvm": { extra properties... }, > >>

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-18 Thread Eric Blake
On 11/18/20 9:45 AM, Eduardo Habkost wrote: > On Wed, Nov 18, 2020 at 02:53:26PM +0100, Markus Armbruster wrote: > [...] >> Another way to skin this cat: >> >> {"available": {"kvm": { extra properties... }, >> "tcg": ..., >> "xen": ...}, >>"ac

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-18 Thread Eduardo Habkost
On Wed, Nov 18, 2020 at 02:53:26PM +0100, Markus Armbruster wrote: [...] > Another way to skin this cat: > > {"available": {"kvm": { extra properties... }, > "tcg": ..., > "xen": ...}, >"active": "kvm"} How would this structure be represente

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-18 Thread Paolo Bonzini
On 18/11/20 15:45, Markus Armbruster wrote: Paolo Bonzini writes: On 18/11/20 14:08, Markus Armbruster wrote: These look like errors, but aren't; things are working exactly as intended, and QEMU runs. If we want to be chatty about it, we should make them info, not error. If there were an i

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-18 Thread Markus Armbruster
Paolo Bonzini writes: > On 18/11/20 14:08, Markus Armbruster wrote: >> These look like errors, but aren't; things are working exactly as >> intended, and QEMU runs. If we want to be chatty about it, we should >> make them info, not error. > > If there were an info_report, I would have sent a pat

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-18 Thread Roman Bolshakov
On Wed, Nov 18, 2020 at 02:08:21PM +0100, Markus Armbruster wrote: > Paolo Bonzini writes: > > On 18/11/20 09:36, Markus Armbruster wrote: > >> While figuring this out, I noticed that the TYPE_ACCEL instance we > >> create doesn't get its parent set. It's therefore not in the QOM > >> composition

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-18 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Nov 18, 2020 at 12:28:45PM +0100, Kevin Wolf wrote: >> Am 18.11.2020 um 09:36 hat Markus Armbruster geschrieben: >> > >> >> [...] Even better would be >> > >> >> returning an array of KvmInfo with information on all suppo

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-18 Thread Paolo Bonzini
On 18/11/20 14:08, Markus Armbruster wrote: These look like errors, but aren't; things are working exactly as intended, and QEMU runs. If we want to be chatty about it, we should make them info, not error. If there were an info_report, I would have sent a patch already. :) In general, these

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-18 Thread Markus Armbruster
Paolo Bonzini writes: > On 18/11/20 09:36, Markus Armbruster wrote: >> >> The part that counts is do_configure_accelerator(). I works as follows: >> >> 1. Look up the chosen accelerator's QOM type (can fail) >> 2. Instantiate it (can't fail) >> 3. Set properties (can fail) >> 4. Connect the ac

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-18 Thread Daniel P . Berrangé
On Wed, Nov 18, 2020 at 12:28:45PM +0100, Kevin Wolf wrote: > Am 18.11.2020 um 09:36 hat Markus Armbruster geschrieben: > > >> >> [...] Even better would be > > >> >> returning an array of KvmInfo with information on all supported > > >> >> accelerators at onc

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-18 Thread Kevin Wolf
Am 18.11.2020 um 09:36 hat Markus Armbruster geschrieben: > >> >> [...] Even better would be > >> >> returning an array of KvmInfo with information on all supported > >> >> accelerators at once, rather than making the user call this command once > >> >> per na

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-18 Thread Paolo Bonzini
On 18/11/20 09:36, Markus Armbruster wrote: The part that counts is do_configure_accelerator(). I works as follows: 1. Look up the chosen accelerator's QOM type (can fail) 2. Instantiate it (can't fail) 3. Set properties (can fail) 4. Connect the accelerator to the current machine (can fail)

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-18 Thread Markus Armbruster
Paolo, there's a question for you further down, marked with your name. Roman Bolshakov writes: > On Tue, Nov 17, 2020 at 09:51:58AM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Mon, Nov 16, 2020 at 10:20:04AM -0600, Eric Blake wrote: >> >> On 11/16/20 7:10 AM, Roman Bo

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-17 Thread Roman Bolshakov
On Tue, Nov 17, 2020 at 09:51:58AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Mon, Nov 16, 2020 at 10:20:04AM -0600, Eric Blake wrote: > >> On 11/16/20 7:10 AM, Roman Bolshakov wrote: > >> > There's a problem for management applications to determine if certain > >> > accel

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-17 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, Nov 16, 2020 at 10:20:04AM -0600, Eric Blake wrote: >> On 11/16/20 7:10 AM, Roman Bolshakov wrote: >> > There's a problem for management applications to determine if certain >> > accelerators available. Generic QMP command should help with that. >> > >> > Signed

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-16 Thread Eduardo Habkost
On Mon, Nov 16, 2020 at 10:20:04AM -0600, Eric Blake wrote: > On 11/16/20 7:10 AM, Roman Bolshakov wrote: > > There's a problem for management applications to determine if certain > > accelerators available. Generic QMP command should help with that. > > > > Signed-off-by: Roman Bolshakov > > ---

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-16 Thread Roman Bolshakov
On Mon, Nov 16, 2020 at 10:20:04AM -0600, Eric Blake wrote: > On 11/16/20 7:10 AM, Roman Bolshakov wrote: > > There's a problem for management applications to determine if certain > > accelerators available. Generic QMP command should help with that. > > > > Signed-off-by: Roman Bolshakov > > ---

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-16 Thread Eric Blake
On 11/16/20 7:10 AM, Roman Bolshakov wrote: > There's a problem for management applications to determine if certain > accelerators available. Generic QMP command should help with that. > > Signed-off-by: Roman Bolshakov > --- > monitor/qmp-cmds.c | 15 +++ > qapi/machine.json | 19 +

[PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-16 Thread Roman Bolshakov
There's a problem for management applications to determine if certain accelerators available. Generic QMP command should help with that. Signed-off-by: Roman Bolshakov --- monitor/qmp-cmds.c | 15 +++ qapi/machine.json | 19 +++ 2 files changed, 34 insertions(+) dif