Re: [PATCH for-6.1 ?] hw/core: fix error checkig in smp_parse

2021-08-13 Thread Paolo Bonzini
On 12/08/21 19:53, Daniel P. Berrangé wrote: The machine_set_smp() mistakenly checks 'errp' not '*errp', and so thinks there is an error every single time it runs. This causes it to jump to the end of the method, skipping the max CPUs checks. The caller meanwhile sees no error and so carries on e

Re: [PATCH for-6.1 ?] hw/core: fix error checkig in smp_parse

2021-08-12 Thread Eduardo Habkost
On Thu, Aug 12, 2021 at 06:53:53PM +0100, Daniel P. Berrangé wrote: > The machine_set_smp() mistakenly checks 'errp' not '*errp', > and so thinks there is an error every single time it runs. > This causes it to jump to the end of the method, skipping > the max CPUs checks. The caller meanwhile sees

[PATCH for-6.1 ?] hw/core: fix error checkig in smp_parse

2021-08-12 Thread Daniel P . Berrangé
The machine_set_smp() mistakenly checks 'errp' not '*errp', and so thinks there is an error every single time it runs. This causes it to jump to the end of the method, skipping the max CPUs checks. The caller meanwhile sees no error and so carries on execution. The result of all this is: $ qemu-s