Re: [PATCH for-7.1 1/8] nbd: actually implement reply_possible safeguard

2022-04-13 Thread Paolo Bonzini
On 4/13/22 00:05, Eric Blake wrote: +s->requests[ind2].reply_possible = nbd_reply_is_structured(&s->reply); If the reply is simple (not structured), then we expect no further replies, so this sets things to false. But if the reply is structured, the answer depends on NBD_REPLY_FLAG_DONE

Re: [PATCH for-7.1 1/8] nbd: actually implement reply_possible safeguard

2022-04-12 Thread Eric Blake
On Tue, Apr 12, 2022 at 09:41:57PM +0200, Paolo Bonzini wrote: > The .reply_possible field of s->requests is never set to false. This is > not a big problem as it is only a safeguard to detect protocol errors, > but fix it anyway. > > Signed-off-by: Paolo Bonzini > --- > block/nbd.c | 9 +--

[PATCH for-7.1 1/8] nbd: actually implement reply_possible safeguard

2022-04-12 Thread Paolo Bonzini
The .reply_possible field of s->requests is never set to false. This is not a big problem as it is only a safeguard to detect protocol errors, but fix it anyway. Signed-off-by: Paolo Bonzini --- block/nbd.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/block/nbd.c