Re: [PATCH for-7.1 2/8] nbd: mark more coroutine_fns

2022-04-13 Thread Paolo Bonzini
On 4/13/22 14:25, Eric Blake wrote: -static bool nbd_recv_coroutine_wake_one(NBDClientRequest *req) +static bool coroutine_fn nbd_recv_coroutine_wake_one(NBDClientRequest *req) This already has_coroutine_ in the name, would it be better as_co_? { if (req->receiving) { req->r

Re: [PATCH for-7.1 2/8] nbd: mark more coroutine_fns

2022-04-13 Thread Eric Blake
On Tue, Apr 12, 2022 at 09:41:58PM +0200, Paolo Bonzini wrote: > Several coroutine functions in block/nbd.c are not marked as such. This > patch adds a few more markers; it is not exhaustive, but it focuses > especially on: > > - places that wake other coroutines, because aio_co_wake() has very >

[PATCH for-7.1 2/8] nbd: mark more coroutine_fns

2022-04-12 Thread Paolo Bonzini
Several coroutine functions in block/nbd.c are not marked as such. This patch adds a few more markers; it is not exhaustive, but it focuses especially on: - places that wake other coroutines, because aio_co_wake() has very different semantics inside a coroutine (queuing after yield vs. entering i