Re: [PATCH for-7.1 3/8] nbd: remove peppering of nbd_client_connected

2022-04-13 Thread Eric Blake
On Tue, Apr 12, 2022 at 09:41:59PM +0200, Paolo Bonzini wrote: > It is unnecessary to check nbd_client_connected() because every time > s->state is moved out of NBD_CLIENT_CONNECTED the socket is shut down > and all coroutines are resumed. > > The only case where it was actually needed is when the

[PATCH for-7.1 3/8] nbd: remove peppering of nbd_client_connected

2022-04-12 Thread Paolo Bonzini
It is unnecessary to check nbd_client_connected() because every time s->state is moved out of NBD_CLIENT_CONNECTED the socket is shut down and all coroutines are resumed. The only case where it was actually needed is when the NBD server disconnects and there is no reconnect-delay. In that case, n