Re: [PATCH for-7.1 6/8] nbd: move s->state under requests_lock

2022-04-13 Thread Paolo Bonzini
On 4/13/22 18:23, Eric Blake wrote: The function nbd_client_connecting_wait() was used mostly to check if a request had to be reissued (outside requests_lock), but also under requests_lock in nbd_client_connecting_wait(). The two uses have to "Function A was used mostly..., but also under requ

Re: [PATCH for-7.1 6/8] nbd: move s->state under requests_lock

2022-04-13 Thread Eric Blake
On Tue, Apr 12, 2022 at 09:42:02PM +0200, Paolo Bonzini wrote: > Remove the confusing, and most likely wrong, atomics. The only function > that used to be somewhat in a hot path was nbd_client_connected(), > but it is not anymore after the previous patches. > > The function nbd_client_connecting_

[PATCH for-7.1 6/8] nbd: move s->state under requests_lock

2022-04-12 Thread Paolo Bonzini
Remove the confusing, and most likely wrong, atomics. The only function that used to be somewhat in a hot path was nbd_client_connected(), but it is not anymore after the previous patches. The function nbd_client_connecting_wait() was used mostly to check if a request had to be reissued (outside