Re: [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices

2022-12-05 Thread Stefano Garzarella
On Thu, Dec 01, 2022 at 04:49:37PM -0500, Michael S. Tsirkin wrote: On Thu, Dec 01, 2022 at 12:21:21PM +, Alex Bennée wrote: "Michael S. Tsirkin" writes: > On Thu, Dec 01, 2022 at 10:14:39AM +, Alex Bennée wrote: >> Do you think rust-vmm's vhost crates have enough of the state >>

Re: [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices

2022-12-01 Thread Michael S. Tsirkin
On Thu, Dec 01, 2022 at 12:21:21PM +, Alex Bennée wrote: > > "Michael S. Tsirkin" writes: > > > On Thu, Dec 01, 2022 at 10:14:39AM +, Alex Bennée wrote: > >> Do you think rust-vmm's vhost crates have enough of the state > >> management to manage vhost and vhost-user backends? Maybe it

Re: [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices

2022-12-01 Thread Alex Bennée
"Michael S. Tsirkin" writes: > On Thu, Dec 01, 2022 at 10:14:39AM +, Alex Bennée wrote: >> Do you think rust-vmm's vhost crates have enough of the state >> management to manage vhost and vhost-user backends? Maybe it would be a >> good experiment in replacing a (small well defined) piece

Re: [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices

2022-12-01 Thread Michael S. Tsirkin
On Thu, Dec 01, 2022 at 10:14:39AM +, Alex Bennée wrote: > Do you think rust-vmm's vhost crates have enough of the state > management to manage vhost and vhost-user backends? Maybe it would be a > good experiment in replacing a (small well defined) piece of > functionality with rust? > > That

Re: [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices

2022-12-01 Thread Alex Bennée
Stefano Garzarella writes: > On Wed, Nov 30, 2022 at 04:03:28PM -0500, Stefan Hajnoczi wrote: >>On Fri, Nov 25, 2022 at 09:12:43AM +0100, Stefano Garzarella wrote: >>> On Thu, Nov 24, 2022 at 01:36:29PM -0500, Stefan Hajnoczi wrote: >>> > On Wed, Nov 23, 2022 at 02:16:30PM +0100, Stefano

Re: [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices

2022-12-01 Thread Stefano Garzarella
On Wed, Nov 30, 2022 at 04:03:28PM -0500, Stefan Hajnoczi wrote: On Fri, Nov 25, 2022 at 09:12:43AM +0100, Stefano Garzarella wrote: On Thu, Nov 24, 2022 at 01:36:29PM -0500, Stefan Hajnoczi wrote: > On Wed, Nov 23, 2022 at 02:16:30PM +0100, Stefano Garzarella wrote: > > Commit 02b61f38d3

Re: [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices

2022-11-30 Thread Michael S. Tsirkin
On Wed, Nov 30, 2022 at 04:03:28PM -0500, Stefan Hajnoczi wrote: > On Fri, Nov 25, 2022 at 09:12:43AM +0100, Stefano Garzarella wrote: > > On Thu, Nov 24, 2022 at 01:36:29PM -0500, Stefan Hajnoczi wrote: > > > On Wed, Nov 23, 2022 at 02:16:30PM +0100, Stefano Garzarella wrote: > > > > Commit

Re: [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices

2022-11-30 Thread Stefan Hajnoczi
On Fri, Nov 25, 2022 at 09:12:43AM +0100, Stefano Garzarella wrote: > On Thu, Nov 24, 2022 at 01:36:29PM -0500, Stefan Hajnoczi wrote: > > On Wed, Nov 23, 2022 at 02:16:30PM +0100, Stefano Garzarella wrote: > > > Commit 02b61f38d3 ("hw/virtio: incorporate backend features in features") > > >

Re: [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices

2022-11-25 Thread Stefano Garzarella
On Thu, Nov 24, 2022 at 01:36:29PM -0500, Stefan Hajnoczi wrote: On Wed, Nov 23, 2022 at 02:16:30PM +0100, Stefano Garzarella wrote: Commit 02b61f38d3 ("hw/virtio: incorporate backend features in features") properly negotiates VHOST_USER_F_PROTOCOL_FEATURES with the vhost-user backend, but we

Re: [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices

2022-11-24 Thread Stefan Hajnoczi
On Wed, Nov 23, 2022 at 02:16:30PM +0100, Stefano Garzarella wrote: > Commit 02b61f38d3 ("hw/virtio: incorporate backend features in features") > properly negotiates VHOST_USER_F_PROTOCOL_FEATURES with the vhost-user > backend, but we forgot to enable vrings as specified in >

Re: [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices

2022-11-24 Thread Raphael Norwitz
> On Nov 24, 2022, at 2:54 AM, Stefano Garzarella wrote: > > On Thu, Nov 24, 2022 at 01:50:19AM -0500, Michael S. Tsirkin wrote: >> On Thu, Nov 24, 2022 at 12:19:25AM +, Raphael Norwitz wrote: >>> >>> > On Nov 23, 2022, at 8:16 AM, Stefano Garzarella >>> > wrote: >>> > >>> > Commit

Re: [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices

2022-11-23 Thread Stefano Garzarella
On Thu, Nov 24, 2022 at 01:50:19AM -0500, Michael S. Tsirkin wrote: On Thu, Nov 24, 2022 at 12:19:25AM +, Raphael Norwitz wrote: > On Nov 23, 2022, at 8:16 AM, Stefano Garzarella wrote: > > Commit 02b61f38d3 ("hw/virtio: incorporate backend features in features") > properly negotiates

Re: [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices

2022-11-23 Thread Michael S. Tsirkin
On Thu, Nov 24, 2022 at 12:19:25AM +, Raphael Norwitz wrote: > > > On Nov 23, 2022, at 8:16 AM, Stefano Garzarella wrote: > > > > Commit 02b61f38d3 ("hw/virtio: incorporate backend features in features") > > properly negotiates VHOST_USER_F_PROTOCOL_FEATURES with the vhost-user > > backend,

Re: [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices

2022-11-23 Thread Raphael Norwitz
> On Nov 23, 2022, at 8:16 AM, Stefano Garzarella wrote: > > Commit 02b61f38d3 ("hw/virtio: incorporate backend features in features") > properly negotiates VHOST_USER_F_PROTOCOL_FEATURES with the vhost-user > backend, but we forgot to enable vrings as specified in >

[PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices

2022-11-23 Thread Stefano Garzarella
Commit 02b61f38d3 ("hw/virtio: incorporate backend features in features") properly negotiates VHOST_USER_F_PROTOCOL_FEATURES with the vhost-user backend, but we forgot to enable vrings as specified in docs/interop/vhost-user.rst: If ``VHOST_USER_F_PROTOCOL_FEATURES`` has not been negotiated,