Re: [PATCH for-7.2 v2 16/20] device_tree.c: support string props in fdt_format_node()

2022-08-10 Thread David Gibson
On Wed, Aug 10, 2022 at 04:40:18PM -0300, Daniel Henrique Barboza wrote: > > > On 8/8/22 01:36, David Gibson wrote: > > On Fri, Aug 05, 2022 at 06:39:44AM -0300, Daniel Henrique Barboza wrote: > > > To support printing string properties in 'info fdt' we need to determine > > > whether a void

Re: [PATCH for-7.2 v2 16/20] device_tree.c: support string props in fdt_format_node()

2022-08-10 Thread Daniel Henrique Barboza
On 8/8/22 01:36, David Gibson wrote: On Fri, Aug 05, 2022 at 06:39:44AM -0300, Daniel Henrique Barboza wrote: To support printing string properties in 'info fdt' we need to determine whether a void data might contain a string. Oh... sorry, obviously I hadn't read these later patches when I

Re: [PATCH for-7.2 v2 16/20] device_tree.c: support string props in fdt_format_node()

2022-08-07 Thread David Gibson
On Fri, Aug 05, 2022 at 06:39:44AM -0300, Daniel Henrique Barboza wrote: > To support printing string properties in 'info fdt' we need to determine > whether a void data might contain a string. Oh... sorry, obviously I hadn't read these later patches when I complained about the command not

[PATCH for-7.2 v2 16/20] device_tree.c: support string props in fdt_format_node()

2022-08-05 Thread Daniel Henrique Barboza
To support printing string properties in 'info fdt' we need to determine whether a void data might contain a string. We do that by casting the void data to a string array and: - check if the array finishes with a null character - check if all characters are printable If both conditions are met,