Re: [PATCH for-7.2 v3 2/3] rtl8139: keep Tx command mode 0 and 1 separate

2022-11-20 Thread Jason Wang
On Fri, Nov 18, 2022 at 12:56 AM Stefan Hajnoczi wrote: > > There are two Tx Descriptor formats called mode 0 and mode 1. The mode > is determined by the Large Send bit. > > CP_TX_IPCS (bit 18) is defined in mode 1 but the code checks the bit > unconditionally. In mode 0 bit 18 is part of the Larg

Re: [PATCH for-7.2 v3 2/3] rtl8139: keep Tx command mode 0 and 1 separate

2022-11-17 Thread Philippe Mathieu-Daudé
On 17/11/22 17:55, Stefan Hajnoczi wrote: There are two Tx Descriptor formats called mode 0 and mode 1. The mode is determined by the Large Send bit. CP_TX_IPCS (bit 18) is defined in mode 1 but the code checks the bit unconditionally. In mode 0 bit 18 is part of the Large Send MSS value. Expli

[PATCH for-7.2 v3 2/3] rtl8139: keep Tx command mode 0 and 1 separate

2022-11-17 Thread Stefan Hajnoczi
There are two Tx Descriptor formats called mode 0 and mode 1. The mode is determined by the Large Send bit. CP_TX_IPCS (bit 18) is defined in mode 1 but the code checks the bit unconditionally. In mode 0 bit 18 is part of the Large Send MSS value. Explicitly check the Large Send bit to distinguis