Re: [PATCH for-8.0 1/1] target/ppc: Use tcg_gen_atomic_cmpxchg_i128 for STQCX

2022-11-21 Thread Richard Henderson
On 11/21/22 14:37, Daniel Henrique Barboza wrote: On 11/12/22 03:11, Richard Henderson wrote: Note that the previous direct reference to reserve_val, -   tcg_gen_ld_i64(t1, cpu_env, (ctx->le_mode -    ? offsetof(CPUPPCState, reserve_val2) - 

Re: [PATCH for-8.0 1/1] target/ppc: Use tcg_gen_atomic_cmpxchg_i128 for STQCX

2022-11-21 Thread Daniel Henrique Barboza
On 11/12/22 03:11, Richard Henderson wrote: Note that the previous direct reference to reserve_val, - tcg_gen_ld_i64(t1, cpu_env, (ctx->le_mode -? offsetof(CPUPPCState, reserve_val2) -: offsetof(CPUPPCState, reserve_val)));

Re: [PATCH for-8.0 1/1] target/ppc: Use tcg_gen_atomic_cmpxchg_i128 for STQCX

2022-11-17 Thread Daniel Henrique Barboza
On 11/16/22 23:48, Richard Henderson wrote: I think you missed the Based-on tag. r~ Duh. Sorry about that. Let me try it again. Daniel On Wed, 16 Nov 2022, 05:38 Daniel Henrique Barboza, mailto:danielhb...@gmail.com>> wrote: Richard, I believe the ppc64-linux-user target

Re: [PATCH for-8.0 1/1] target/ppc: Use tcg_gen_atomic_cmpxchg_i128 for STQCX

2022-11-16 Thread Richard Henderson
I think you missed the Based-on tag. r~ On Wed, 16 Nov 2022, 05:38 Daniel Henrique Barboza, wrote: > Richard, > > I believe the ppc64-linux-user target didn't like what you did in this > patch. Here's the error: > > $ ../configure >

Re: [PATCH for-8.0 1/1] target/ppc: Use tcg_gen_atomic_cmpxchg_i128 for STQCX

2022-11-16 Thread Daniel Henrique Barboza
Richard, I believe the ppc64-linux-user target didn't like what you did in this patch. Here's the error: $ ../configure --target-list=ppc64-softmmu,ppc64-linux-user,ppc-softmmu,ppc-linux-user,ppc64le-linux-user $ make -j (...) [15/133] Compiling C object

[PATCH for-8.0 1/1] target/ppc: Use tcg_gen_atomic_cmpxchg_i128 for STQCX

2022-11-11 Thread Richard Henderson
Note that the previous direct reference to reserve_val, - tcg_gen_ld_i64(t1, cpu_env, (ctx->le_mode -? offsetof(CPUPPCState, reserve_val2) -: offsetof(CPUPPCState, reserve_val))); was incorrect because all references should have