Re: [PATCH for-8.2 2/6] sysemu: Add pre VM state change callback

2023-07-30 Thread Cédric Le Goater
[ ... ] + * qemu_add_vm_change_state_handler_prio_full: qemu_add_vm_change_state_handler_prio_all() may be. I don't have much better but 'full' doesn't sound right. minor. I followed the GLib naming convention. For example, g_tree_new and g_tree_new_full, or g_hash_table_new and

Re: [PATCH for-8.2 2/6] sysemu: Add pre VM state change callback

2023-07-30 Thread Avihai Horon
On 27/07/2023 19:23, Cédric Le Goater wrote: External email: Use caution opening links or attachments On 7/16/23 10:15, Avihai Horon wrote: Add pre VM state change callback to struct VMChangeStateEntry. This sentence could be the subject. Sure. The pre VM state change callback is

Re: [PATCH for-8.2 2/6] sysemu: Add pre VM state change callback

2023-07-27 Thread Cédric Le Goater
On 7/16/23 10:15, Avihai Horon wrote: Add pre VM state change callback to struct VMChangeStateEntry. This sentence could be the subject. The pre VM state change callback is optional and can be set by the new function qemu_add_vm_change_state_handler_prio_full() that allows setting this

[PATCH for-8.2 2/6] sysemu: Add pre VM state change callback

2023-07-16 Thread Avihai Horon
Add pre VM state change callback to struct VMChangeStateEntry. The pre VM state change callback is optional and can be set by the new function qemu_add_vm_change_state_handler_prio_full() that allows setting this callback in addition to the main callback. The pre VM state change callbacks and