Re: [PATCH for-8.2 3/4] migration/qapi: Replace @MigrateSetParameters with @MigrationParameters

2023-08-25 Thread Peter Xu
On Mon, Aug 14, 2023 at 06:19:46PM -0400, Peter Xu wrote: > Here to deduplicate the two objects, logically it'll be safe only if we use > "StrOrNull" to replace "str" type, not vice versa. However we may face > difficulty using StrOrNull as part of MigrationState.parameters [1] when > replacing ex

Re: [PATCH for-8.2 3/4] migration/qapi: Replace @MigrateSetParameters with @MigrationParameters

2023-08-23 Thread Peter Xu
On Wed, Aug 23, 2023 at 03:26:25PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > These two structs are mostly identical besides some fields (quote from > > Daniel P. Berrangé in his reply): > > > > 1c1 > > < { 'struct': 'MigrationParameters', > > --- > > > { 'struct': 'MigrateS

Re: [PATCH for-8.2 3/4] migration/qapi: Replace @MigrateSetParameters with @MigrationParameters

2023-08-23 Thread Markus Armbruster
Peter Xu writes: > These two structs are mostly identical besides some fields (quote from > Daniel P. Berrangé in his reply): > > 1c1 > < { 'struct': 'MigrationParameters', > --- > > { 'struct': 'MigrateSetParameters', > 14,16c14,16 > < '*tls-creds': 'str', > <

[PATCH for-8.2 3/4] migration/qapi: Replace @MigrateSetParameters with @MigrationParameters

2023-08-14 Thread Peter Xu
These two structs are mostly identical besides some fields (quote from Daniel P. Berrangé in his reply): 1c1 < { 'struct': 'MigrationParameters', --- > { 'struct': 'MigrateSetParameters', 14,16c14,16 < '*tls-creds': 'str', < '*tls-hostname': 'str', <