Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-07 Thread Eric Auger
Hi Peter, On 12/7/22 21:28, Peter Maydell wrote: > On Wed, 7 Dec 2022 at 18:44, Eric Auger wrote: >> On 12/7/22 19:23, Richard Henderson wrote: >>> Adding -Wall is not standard, nor all the other -W that you are >>> adding. I think you should not be surprised that you run into problems. >> OK

Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-07 Thread Peter Maydell
On Wed, 7 Dec 2022 at 18:44, Eric Auger wrote: > On 12/7/22 19:23, Richard Henderson wrote: > > Adding -Wall is not standard, nor all the other -W that you are > > adding. I think you should not be surprised that you run into problems. > OK that's a useful indication. I used to have this

Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-07 Thread Eric Auger
Hi Stefan, On 12/7/22 20:11, Stefan Weil via wrote: > Am 07.12.22 um 19:22 schrieb Eric Auger: >> >> On 12/7/22 17:55, Philippe Mathieu-Daudé wrote: >>> On 7/12/22 15:33, Eric Auger wrote: On 12/7/22 15:09, Stefan Hajnoczi wrote: > On Wed, 7 Dec 2022 at 08:31, Eric Auger > wrote:

Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-07 Thread Eric Auger
Hi Stefan, On 12/7/22 20:59, Stefan Hajnoczi wrote: > On Wed, 7 Dec 2022 at 14:11, Stefan Weil wrote: >> Am 07.12.22 um 19:22 schrieb Eric Auger: >>> On 12/7/22 17:55, Philippe Mathieu-Daudé wrote: On 7/12/22 15:33, Eric Auger wrote: > On 12/7/22 15:09, Stefan Hajnoczi wrote: >> On

Compiler warnings with maximum warning level (was: Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized)

2022-12-07 Thread Stefan Weil via
Am 07.12.22 um 20:11 schrieb Stefan Weil: On 12/7/22 14:24, Eric Auger wrote: Initialize r0-3 to avoid compilation errors when -Werror=maybe-uninitialized is used ../target/i386/ops_sse.h: In function ‘helper_vpermdq_ymm’: ../target/i386/ops_sse.h:2495:13: error: ‘r3’ may be used uninitialized

Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-07 Thread Stefan Hajnoczi
On Wed, 7 Dec 2022 at 14:11, Stefan Weil wrote: > > Am 07.12.22 um 19:22 schrieb Eric Auger: > > > > On 12/7/22 17:55, Philippe Mathieu-Daudé wrote: > >> On 7/12/22 15:33, Eric Auger wrote: > >>> On 12/7/22 15:09, Stefan Hajnoczi wrote: > On Wed, 7 Dec 2022 at 08:31, Eric Auger wrote: >

Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-07 Thread Stefan Weil via
Am 07.12.22 um 19:22 schrieb Eric Auger: On 12/7/22 17:55, Philippe Mathieu-Daudé wrote: On 7/12/22 15:33, Eric Auger wrote: On 12/7/22 15:09, Stefan Hajnoczi wrote: On Wed, 7 Dec 2022 at 08:31, Eric Auger wrote: On 12/7/22 14:24, Eric Auger wrote: Initialize r0-3 to avoid compilation

Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-07 Thread Eric Auger
Hi, On 12/7/22 19:23, Richard Henderson wrote: > On 12/7/22 10:08, Eric Auger wrote: >> On 12/7/22 16:55, Stefan Hajnoczi wrote: I am using this configure cmd line: ./configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib/qemu --target-list=x86_64-softmmu

Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-07 Thread Richard Henderson
On 12/7/22 10:08, Eric Auger wrote: On 12/7/22 16:55, Stefan Hajnoczi wrote: I am using this configure cmd line: ./configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib/qemu --target-list=x86_64-softmmu --docdir=/usr/share/doc/qemu --enable-kvm --extra-cflags=-O

Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-07 Thread Eric Auger
On 12/7/22 17:55, Philippe Mathieu-Daudé wrote: > On 7/12/22 15:33, Eric Auger wrote: >> On 12/7/22 15:09, Stefan Hajnoczi wrote: >>> On Wed, 7 Dec 2022 at 08:31, Eric Auger wrote: On 12/7/22 14:24, Eric Auger wrote: > Initialize r0-3 to avoid compilation errors when >

Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-07 Thread Philippe Mathieu-Daudé
On 7/12/22 15:33, Eric Auger wrote: On 12/7/22 15:09, Stefan Hajnoczi wrote: On Wed, 7 Dec 2022 at 08:31, Eric Auger wrote: On 12/7/22 14:24, Eric Auger wrote: Initialize r0-3 to avoid compilation errors when -Werror=maybe-uninitialized is used ../target/i386/ops_sse.h: In function

Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-07 Thread Eric Auger
Hi Stefan, On 12/7/22 16:55, Stefan Hajnoczi wrote: > On Wed, 7 Dec 2022 at 09:34, Eric Auger wrote: >> Hi Stefan, >> >> On 12/7/22 15:09, Stefan Hajnoczi wrote: >>> On Wed, 7 Dec 2022 at 08:31, Eric Auger wrote: On 12/7/22 14:24, Eric Auger wrote: > Initialize r0-3 to avoid

Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-07 Thread Stefan Hajnoczi
On Wed, 7 Dec 2022 at 09:34, Eric Auger wrote: > > Hi Stefan, > > On 12/7/22 15:09, Stefan Hajnoczi wrote: > > On Wed, 7 Dec 2022 at 08:31, Eric Auger wrote: > >> On 12/7/22 14:24, Eric Auger wrote: > >>> Initialize r0-3 to avoid compilation errors when > >>> -Werror=maybe-uninitialized is used

Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-07 Thread Eric Auger
Hi Stefan, On 12/7/22 15:09, Stefan Hajnoczi wrote: > On Wed, 7 Dec 2022 at 08:31, Eric Auger wrote: >> On 12/7/22 14:24, Eric Auger wrote: >>> Initialize r0-3 to avoid compilation errors when >>> -Werror=maybe-uninitialized is used >>> >>> ../target/i386/ops_sse.h: In function

Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-07 Thread Stefan Hajnoczi
On Wed, 7 Dec 2022 at 08:31, Eric Auger wrote: > On 12/7/22 14:24, Eric Auger wrote: > > Initialize r0-3 to avoid compilation errors when > > -Werror=maybe-uninitialized is used > > > > ../target/i386/ops_sse.h: In function ‘helper_vpermdq_ymm’: > > ../target/i386/ops_sse.h:2495:13: error: ‘r3’

Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-07 Thread Eric Auger
On 12/7/22 14:24, Eric Auger wrote: > Initialize r0-3 to avoid compilation errors when > -Werror=maybe-uninitialized is used > > ../target/i386/ops_sse.h: In function ‘helper_vpermdq_ymm’: > ../target/i386/ops_sse.h:2495:13: error: ‘r3’ may be used uninitialized in > this function

[PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-07 Thread Eric Auger
Initialize r0-3 to avoid compilation errors when -Werror=maybe-uninitialized is used ../target/i386/ops_sse.h: In function ‘helper_vpermdq_ymm’: ../target/i386/ops_sse.h:2495:13: error: ‘r3’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 2495 | d->Q(3) = r3;