Re: [PATCH qemu v2 2/2] tests/tcg/aarch64: Add testcases for IC IVAU and dual-mapped code

2023-06-19 Thread John Högberg
Thanks for the review! :) > All new source files must start with a license-and-copyright comment. > ... snip ... > Generally in QEMU we prefer to typedef the function type, not the pointer-to-function type. > ... snip ... > You should probably mark all these asm statements as 'volatile' > to ensur

Re: [PATCH qemu v2 2/2] tests/tcg/aarch64: Add testcases for IC IVAU and dual-mapped code

2023-06-19 Thread Peter Maydell
On Mon, 19 Jun 2023 at 15:31, John Högberg wrote: > > Thanks for the review! :) > > > All new source files must start with a license-and-copyright > comment. > > ... snip ... > > Generally in QEMU we prefer to typedef the function type, > not the pointer-to-function type. > > ... snip ... > > You

Re: [PATCH qemu v2 2/2] tests/tcg/aarch64: Add testcases for IC IVAU and dual-mapped code

2023-06-19 Thread Peter Maydell
On Mon, 12 Jun 2023 at 10:40, ~jhogberg wrote: > > From: John Högberg > > https://gitlab.com/qemu-project/qemu/-/issues/1034 > > Signed-off-by: John Högberg > diff --git a/tests/tcg/aarch64/icivau.c b/tests/tcg/aarch64/icivau.c > new file mode 100644 > index 00..ff80d3d868 > --- /dev/nu

[PATCH qemu v2 2/2] tests/tcg/aarch64: Add testcases for IC IVAU and dual-mapped code

2023-06-12 Thread ~jhogberg
From: John Högberg https://gitlab.com/qemu-project/qemu/-/issues/1034 Signed-off-by: John Högberg --- tests/tcg/aarch64/Makefile.target | 3 +- tests/tcg/aarch64/icivau.c| 204 ++ 2 files changed, 206 insertions(+), 1 deletion(-) create mode 100644 tests/