Re: [PATCH qemu v23] spapr: Fix implementation of Open Firmware client interface

2021-07-09 Thread BALATON Zoltan
On Fri, 9 Jul 2021, Alexey Kardashevskiy wrote: On 09/07/2021 23:28, BALATON Zoltan wrote: On Fri, 9 Jul 2021, Alexey Kardashevskiy wrote: On 09/07/2021 08:34, BALATON Zoltan wrote: MorphOS still boots but this breaks Linux which changes a few things in the device tree to fix it up to make it

Re: [PATCH qemu v23] spapr: Fix implementation of Open Firmware client interface

2021-07-09 Thread Alexey Kardashevskiy
On 09/07/2021 23:28, BALATON Zoltan wrote: On Fri, 9 Jul 2021, Alexey Kardashevskiy wrote: On 09/07/2021 08:34, BALATON Zoltan wrote: MorphOS still boots but this breaks Linux which changes a few things in the device tree to fix it up to make it look the way it thinks is better. What are

Re: [PATCH qemu v23] spapr: Fix implementation of Open Firmware client interface

2021-07-09 Thread BALATON Zoltan
On Fri, 9 Jul 2021, David Gibson wrote: On Thu, Jul 08, 2021 at 03:00:22PM +0200, BALATON Zoltan wrote: On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote: On 08/07/2021 20:39, BALATON Zoltan wrote: On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote: On 08/07/2021 20:18, BALATON Zoltan wrote: On Thu

Re: [PATCH qemu v23] spapr: Fix implementation of Open Firmware client interface

2021-07-09 Thread BALATON Zoltan
On Fri, 9 Jul 2021, Alexey Kardashevskiy wrote: On 09/07/2021 08:34, BALATON Zoltan wrote: MorphOS still boots but this breaks Linux which changes a few things in the device tree to fix it up to make it look the way it thinks is better. What are those things? What does the change break precis

Re: [PATCH qemu v23] spapr: Fix implementation of Open Firmware client interface

2021-07-08 Thread Alexey Kardashevskiy
On 09/07/2021 08:34, BALATON Zoltan wrote: On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote: This addresses the comments from v22. The functional changes are (the VOF ones need retesting with Pegasos2): (VOF) setprop will start failing if the machine class callback did not handle it; (VOF) un

Re: [PATCH qemu v23] spapr: Fix implementation of Open Firmware client interface

2021-07-08 Thread David Gibson
On Thu, Jul 08, 2021 at 04:56:25PM +1000, Alexey Kardashevskiy wrote: > This addresses the comments from v22. > > The functional changes are (the VOF ones need retesting with Pegasos2): > > (VOF) setprop will start failing if the machine class callback > did not handle it; > (VOF) unit addresses

Re: [PATCH qemu v23] spapr: Fix implementation of Open Firmware client interface

2021-07-08 Thread David Gibson
On Thu, Jul 08, 2021 at 03:00:22PM +0200, BALATON Zoltan wrote: > On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote: > > On 08/07/2021 20:39, BALATON Zoltan wrote: > > > On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote: > > > > On 08/07/2021 20:18, BALATON Zoltan wrote: > > > > > On Thu, 8 Jul 2021, Ale

Re: [PATCH qemu v23] spapr: Fix implementation of Open Firmware client interface

2021-07-08 Thread BALATON Zoltan
On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote: This addresses the comments from v22. The functional changes are (the VOF ones need retesting with Pegasos2): (VOF) setprop will start failing if the machine class callback did not handle it; (VOF) unit addresses are lowered in path_offset(); (SPA

Re: [PATCH qemu v23] spapr: Fix implementation of Open Firmware client interface

2021-07-08 Thread BALATON Zoltan
On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote: On 08/07/2021 20:39, BALATON Zoltan wrote: On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote: On 08/07/2021 20:18, BALATON Zoltan wrote: On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote: This addresses the comments from v22. The functional changes a

Re: [PATCH qemu v23] spapr: Fix implementation of Open Firmware client interface

2021-07-08 Thread Alexey Kardashevskiy
On 08/07/2021 20:39, BALATON Zoltan wrote: On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote: On 08/07/2021 20:18, BALATON Zoltan wrote: On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote: This addresses the comments from v22. The functional changes are (the VOF ones need retesting with Pegasos2)

Re: [PATCH qemu v23] spapr: Fix implementation of Open Firmware client interface

2021-07-08 Thread BALATON Zoltan
On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote: On 08/07/2021 20:18, BALATON Zoltan wrote: On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote: This addresses the comments from v22. The functional changes are (the VOF ones need retesting with Pegasos2): (VOF) setprop will start failing if the mach

Re: [PATCH qemu v23] spapr: Fix implementation of Open Firmware client interface

2021-07-08 Thread Alexey Kardashevskiy
On 08/07/2021 20:18, BALATON Zoltan wrote: On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote: This addresses the comments from v22. The functional changes are (the VOF ones need retesting with Pegasos2): (VOF) setprop will start failing if the machine class callback did not handle it; I'll t

Re: [PATCH qemu v23] spapr: Fix implementation of Open Firmware client interface

2021-07-08 Thread BALATON Zoltan
On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote: This addresses the comments from v22. The functional changes are (the VOF ones need retesting with Pegasos2): (VOF) setprop will start failing if the machine class callback did not handle it; I'll try this later but I think I've seen guests usin

[PATCH qemu v23] spapr: Fix implementation of Open Firmware client interface

2021-07-07 Thread Alexey Kardashevskiy
This addresses the comments from v22. The functional changes are (the VOF ones need retesting with Pegasos2): (VOF) setprop will start failing if the machine class callback did not handle it; (VOF) unit addresses are lowered in path_offset(); (SPAPR) /chosen/bootargs is initialized from kernel_cm