Re: [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic

Hi Richard, On 1/27/20 2:38 PM, Michael Rolnik wrote: Hi Joaquin. I looks like that the CPU families are not well defined. There are some small variations within the families themselves i.e. some MCUs do not support all the features of their families. To get the features I looked at this

Re: [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic

Hi Joaquin. I looks like that the CPU families are not well defined. There are some small variations within the families themselves i.e. some MCUs do not support all the features of their families. To get the features I looked at this file in gcc

Re: [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic

On 1/24/20 1:51 AM, Philippe Mathieu-Daudé wrote: > From: Michael Rolnik > > This includes: > - CPU data structures > - object model classes and functions > - migration functions > - GDB hooks > > Co-developed-by: Michael Rolnik > Co-developed-by: Sarah Harris > Signed-off-by: Michael Rolnik

Re: [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic

On 1/27/20 10:48 AM, Michael Rolnik wrote: > Not used. it's there just for clarity. to follow the pattern like PC > > AVR_FEATURE_1_BYTE_PC, > AVR_FEATURE_2_BYTE_PC, > AVR_FEATURE_3_BYTE_PC, > > AVR_FEATURE_1_BYTE_SP, > AVR_FEATURE_2_BYTE_SP, > > To show that there is

Re: [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic

Sorry, I was thinking in one and put the other, I mean 'AVR_FEATURE_1_BYTE_SP'. --joa On 1/27/20 9:53 AM, Michael Rolnik wrote: > Hi Joaquin. > > `AVR_FEATURE_1_BYTE_PC` is used in `gen_push_ret` function > (target/avr/translate.c) > > Regards, > Michael Rolnik > > On Sun, Jan 26, 2020 at

Re: [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic

Hi Joaquin. `AVR_FEATURE_1_BYTE_PC` is used in `gen_push_ret` function (target/avr/translate.c) Regards, Michael Rolnik On Sun, Jan 26, 2020 at 2:15 PM Joaquin de Andres wrote: > Hi! In this mail I only checked the general code and one of the listed > features for the different types of avr.

Re: [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic

On Sun, Jan 26, 2020 at 1:15 PM Joaquin de Andres wrote: > > +struct CPUAVRState { > > +uint32_t pc_w; /* 0x003f up to 22 bits */ > > + > > +uint32_t sregC; /* 0x0001 1 bit */ > > +uint32_t sregZ; /* 0x0001 1 bit */ > > +uint32_t sregN; /* 0x0001 1 bit */ > > +

Re: [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic

Hi! In this mail I only checked the general code and one of the listed features for the different types of avr. I will check the rest in following emails. On 1/24/20 1:51 AM, Philippe Mathieu-Daudé wrote: > From: Michael Rolnik > > This includes: > - CPU data structures > - object model classes

Re: [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic

On 25/01/2020 11.48, Aleksandar Markovic wrote: > > On Friday, January 24, 2020, Philippe Mathieu-Daudé > wrote: > > From: Michael Rolnik mailto:mrol...@gmail.com>> > > This includes: > - CPU data structures > - object model classes and functions > -

Re: [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic

On Friday, January 24, 2020, Philippe Mathieu-Daudé wrote: > From: Michael Rolnik > > This includes: > - CPU data structures > - object model classes and functions > - migration functions > - GDB hooks > > I have an objection over this patch. It contains many diverse logical units squashed

[PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic

From: Michael Rolnik This includes: - CPU data structures - object model classes and functions - migration functions - GDB hooks Co-developed-by: Michael Rolnik Co-developed-by: Sarah Harris Signed-off-by: Michael Rolnik Signed-off-by: Sarah Harris Signed-off-by: Michael Rolnik Acked-by: