Re: [PATCH v1] block/raw-format: implement .bdrv_get_specific_info handler

2021-07-07 Thread Kevin Wolf
--- > To: "Or Ozeri" <[2]o...@il.ibm.com> > From: "Kevin Wolf" <[3]kw...@redhat.com> > Date: 07/07/2021 10:52AM > Cc: [4]qemu-devel@nongnu.org, [5]qemu-bl...@nongnu.org, [6] > to.my.troc...@gmail.com, [7]dan...@il.ibm.com, [8]berra...@redhat.com, [9

RE: [PATCH v1] block/raw-format: implement .bdrv_get_specific_info handler

2021-07-07 Thread Or Ozeri
Would you suggest to do this child traversal on bdrv_query_image_info, and have it returned as part of the ImageInfo struct?In that case, I would add *driver-specific to ImageInfo, in addition to the existing *format-specific?Or should I just do the traversal in img_info (qemu-img.c), avoiding the

Re: [PATCH v1] block/raw-format: implement .bdrv_get_specific_info handler

2021-07-07 Thread Kevin Wolf
Am 07.07.2021 um 07:35 hat Or Ozeri geschrieben: > When using the raw format, allow exposing specific info by the underlying > storage. > In particular, this will enable RBD images using the raw format to indicate > a LUKS2 encrypted image in the output of qemu-img info. > > Signed-off-by: Or

[PATCH v1] block/raw-format: implement .bdrv_get_specific_info handler

2021-07-06 Thread Or Ozeri
When using the raw format, allow exposing specific info by the underlying storage. In particular, this will enable RBD images using the raw format to indicate a LUKS2 encrypted image in the output of qemu-img info. Signed-off-by: Or Ozeri --- block/raw-format.c | 7 +++ 1 file changed, 7