Re: [PATCH v1] libvhost-user: fix VHOST_USER_REM_MEM_REG not closing the fd

2021-10-14 Thread Raphael Norwitz
On Thu, Oct 14, 2021 at 09:06:51AM +0200, David Hildenbrand wrote: > On 14.10.21 07:29, Raphael Norwitz wrote: > > On Wed, Oct 13, 2021 at 11:51:24AM +0200, David Hildenbrand wrote: > >> On 13.10.21 11:48, Stefan Hajnoczi wrote: > >>> On Tue, Oct 12, 2021 at 08:38:32PM +0200, David Hildenbrand wrot

Re: [PATCH v1] libvhost-user: fix VHOST_USER_REM_MEM_REG not closing the fd

2021-10-14 Thread David Hildenbrand
On 14.10.21 07:29, Raphael Norwitz wrote: > On Wed, Oct 13, 2021 at 11:51:24AM +0200, David Hildenbrand wrote: >> On 13.10.21 11:48, Stefan Hajnoczi wrote: >>> On Tue, Oct 12, 2021 at 08:38:32PM +0200, David Hildenbrand wrote: We end up not closing the file descriptor, resulting in leaking one

Re: [PATCH v1] libvhost-user: fix VHOST_USER_REM_MEM_REG not closing the fd

2021-10-13 Thread Raphael Norwitz
On Wed, Oct 13, 2021 at 11:51:24AM +0200, David Hildenbrand wrote: > On 13.10.21 11:48, Stefan Hajnoczi wrote: > > On Tue, Oct 12, 2021 at 08:38:32PM +0200, David Hildenbrand wrote: > > > We end up not closing the file descriptor, resulting in leaking one > > > file descriptor for each VHOST_USER_R

Re: [PATCH v1] libvhost-user: fix VHOST_USER_REM_MEM_REG not closing the fd

2021-10-13 Thread David Hildenbrand
On 13.10.21 11:48, Stefan Hajnoczi wrote: On Tue, Oct 12, 2021 at 08:38:32PM +0200, David Hildenbrand wrote: We end up not closing the file descriptor, resulting in leaking one file descriptor for each VHOST_USER_REM_MEM_REG message. Fixes: 875b9fd97b34 ("Support individual region unmap in libv

Re: [PATCH v1] libvhost-user: fix VHOST_USER_REM_MEM_REG not closing the fd

2021-10-13 Thread Stefan Hajnoczi
On Tue, Oct 12, 2021 at 08:38:32PM +0200, David Hildenbrand wrote: > We end up not closing the file descriptor, resulting in leaking one > file descriptor for each VHOST_USER_REM_MEM_REG message. > > Fixes: 875b9fd97b34 ("Support individual region unmap in libvhost-user") > Cc: Michael S. Tsirkin

Re: [PATCH v1] libvhost-user: fix VHOST_USER_REM_MEM_REG not closing the fd

2021-10-12 Thread Raphael Norwitz
On Tue, Oct 12, 2021 at 08:38:32PM +0200, David Hildenbrand wrote: > We end up not closing the file descriptor, resulting in leaking one > file descriptor for each VHOST_USER_REM_MEM_REG message. > > Fixes: 875b9fd97b34 ("Support individual region unmap in libvhost-user") > Cc: Michael S. Tsirkin

[PATCH v1] libvhost-user: fix VHOST_USER_REM_MEM_REG not closing the fd

2021-10-12 Thread David Hildenbrand
We end up not closing the file descriptor, resulting in leaking one file descriptor for each VHOST_USER_REM_MEM_REG message. Fixes: 875b9fd97b34 ("Support individual region unmap in libvhost-user") Cc: Michael S. Tsirkin Cc: Raphael Norwitz Cc: "Marc-André Lureau" Cc: Stefan Hajnoczi Cc: Paolo