Re: [PATCH v1] pc: Support coldplugging of virtio-pmem-pci devices on all buses

2020-06-09 Thread David Hildenbrand
On 09.06.20 17:47, Michael S. Tsirkin wrote: > On Mon, May 25, 2020 at 10:45:11AM +0200, David Hildenbrand wrote: >> E.g., with "pc-q35-4.2", trying to coldplug a virtio-pmem-pci devices >> results in >> "virtio-pmem-pci not supported on this bus" >> >> Reasons is, that the bus does not support

Re: [PATCH v1] pc: Support coldplugging of virtio-pmem-pci devices on all buses

2020-06-09 Thread Michael S. Tsirkin
On Mon, May 25, 2020 at 10:45:11AM +0200, David Hildenbrand wrote: > E.g., with "pc-q35-4.2", trying to coldplug a virtio-pmem-pci devices > results in > "virtio-pmem-pci not supported on this bus" > > Reasons is, that the bus does not support hotplug and, therefore, does > not have a hotplug

Re: [PATCH v1] pc: Support coldplugging of virtio-pmem-pci devices on all buses

2020-05-27 Thread Pankaj Gupta
Hi David, Vivek, s > >> Hi Vivek, > >> > >> you have to declare the maxMemory option. Memory devices like > >> virtio-pmem-pci reside in RAM like a pc-dimm or a nvdimm. If your > >> virtio-pmem device will be 4GB, you have to add that to maxMemory. > >> > >> 64 > >> 68 > >> 64 > >> > >> (you

Re: [PATCH v1] pc: Support coldplugging of virtio-pmem-pci devices on all buses

2020-05-26 Thread Daniel P . Berrangé
On Tue, May 26, 2020 at 04:43:35PM +0200, David Hildenbrand wrote: > On 26.05.20 16:22, Vivek Goyal wrote: > > On Tue, May 26, 2020 at 03:44:10PM +0200, David Hildenbrand wrote: > >> On 26.05.20 15:28, Vivek Goyal wrote: > >>> On Mon, May 25, 2020 at 10:45:11AM +0200, David Hildenbrand wrote: > >>>

Re: [PATCH v1] pc: Support coldplugging of virtio-pmem-pci devices on all buses

2020-05-26 Thread David Hildenbrand
On 26.05.20 16:22, Vivek Goyal wrote: > On Tue, May 26, 2020 at 03:44:10PM +0200, David Hildenbrand wrote: >> On 26.05.20 15:28, Vivek Goyal wrote: >>> On Mon, May 25, 2020 at 10:45:11AM +0200, David Hildenbrand wrote: E.g., with "pc-q35-4.2", trying to coldplug a virtio-pmem-pci devices

Re: [PATCH v1] pc: Support coldplugging of virtio-pmem-pci devices on all buses

2020-05-26 Thread Vivek Goyal
On Tue, May 26, 2020 at 03:44:10PM +0200, David Hildenbrand wrote: > On 26.05.20 15:28, Vivek Goyal wrote: > > On Mon, May 25, 2020 at 10:45:11AM +0200, David Hildenbrand wrote: > >> E.g., with "pc-q35-4.2", trying to coldplug a virtio-pmem-pci devices > >> results in > >> "virtio-pmem-pci not

Re: [PATCH v1] pc: Support coldplugging of virtio-pmem-pci devices on all buses

2020-05-26 Thread David Hildenbrand
On 26.05.20 15:28, Vivek Goyal wrote: > On Mon, May 25, 2020 at 10:45:11AM +0200, David Hildenbrand wrote: >> E.g., with "pc-q35-4.2", trying to coldplug a virtio-pmem-pci devices >> results in >> "virtio-pmem-pci not supported on this bus" >> >> Reasons is, that the bus does not support hotplu

Re: [PATCH v1] pc: Support coldplugging of virtio-pmem-pci devices on all buses

2020-05-26 Thread Vivek Goyal
On Mon, May 25, 2020 at 10:45:11AM +0200, David Hildenbrand wrote: > E.g., with "pc-q35-4.2", trying to coldplug a virtio-pmem-pci devices > results in > "virtio-pmem-pci not supported on this bus" > > Reasons is, that the bus does not support hotplug and, therefore, does > not have a hotplug

Re: [PATCH v1] pc: Support coldplugging of virtio-pmem-pci devices on all buses

2020-05-25 Thread Pankaj Gupta
> E.g., with "pc-q35-4.2", trying to coldplug a virtio-pmem-pci devices > results in > "virtio-pmem-pci not supported on this bus" > > Reasons is, that the bus does not support hotplug and, therefore, does > not have a hotplug handler. Let's allow coldplugging virtio-pmem devices > on such buse

[PATCH v1] pc: Support coldplugging of virtio-pmem-pci devices on all buses

2020-05-25 Thread David Hildenbrand
E.g., with "pc-q35-4.2", trying to coldplug a virtio-pmem-pci devices results in "virtio-pmem-pci not supported on this bus" Reasons is, that the bus does not support hotplug and, therefore, does not have a hotplug handler. Let's allow coldplugging virtio-pmem devices on such buses. The hotplu