Re: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-11 Thread Daniel P . Berrangé
On Thu, Jul 11, 2024 at 03:09:28PM +, Wang, Wei W wrote: > On Thursday, July 11, 2024 10:14 PM, Daniel P. Berrangé wrote: > > On Thu, Jul 11, 2024 at 02:13:31PM +, Wang, Wei W wrote: > > > On Thursday, July 11, 2024 8:25 PM, Daniel P. Berrangé wrote: > > > > On Thu, Jul 11, 2024 at 12:10:34

RE: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-11 Thread Wang, Wei W
On Thursday, July 11, 2024 10:14 PM, Daniel P. Berrangé wrote: > On Thu, Jul 11, 2024 at 02:13:31PM +, Wang, Wei W wrote: > > On Thursday, July 11, 2024 8:25 PM, Daniel P. Berrangé wrote: > > > On Thu, Jul 11, 2024 at 12:10:34PM +, Wang, Wei W wrote: > > > > On Thursday, July 11, 2024 7:48

Re: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-11 Thread Daniel P . Berrangé
On Thu, Jul 11, 2024 at 02:13:31PM +, Wang, Wei W wrote: > On Thursday, July 11, 2024 8:25 PM, Daniel P. Berrangé wrote: > > On Thu, Jul 11, 2024 at 12:10:34PM +, Wang, Wei W wrote: > > > On Thursday, July 11, 2024 7:48 PM, Daniel P. Berrangé wrote: > > > > On Wed, Jul 03, 2024 at 10:49:12P

RE: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-11 Thread Wang, Wei W
On Thursday, July 11, 2024 8:25 PM, Daniel P. Berrangé wrote: > On Thu, Jul 11, 2024 at 12:10:34PM +, Wang, Wei W wrote: > > On Thursday, July 11, 2024 7:48 PM, Daniel P. Berrangé wrote: > > > On Wed, Jul 03, 2024 at 10:49:12PM +0800, Wei Wang wrote: > > AFAIK, many users are not aware of this,

Re: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-11 Thread Daniel P . Berrangé
On Thu, Jul 11, 2024 at 01:48:59PM +, Wang, Wei W wrote: > On Thursday, July 11, 2024 8:25 PM, Daniel P. Berrangé wrote: > > On Thu, Jul 11, 2024 at 12:10:34PM +, Wang, Wei W wrote: > > > On Thursday, July 11, 2024 7:48 PM, Daniel P. Berrangé wrote: > > > > On Wed, Jul 03, 2024 at 10:49:12P

RE: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-11 Thread Wang, Wei W
On Thursday, July 11, 2024 8:25 PM, Daniel P. Berrangé wrote: > On Thu, Jul 11, 2024 at 12:10:34PM +, Wang, Wei W wrote: > > On Thursday, July 11, 2024 7:48 PM, Daniel P. Berrangé wrote: > > > On Wed, Jul 03, 2024 at 10:49:12PM +0800, Wei Wang wrote: > > > > When enforce_cpuid is set to false,

Re: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-11 Thread Daniel P . Berrangé
On Thu, Jul 11, 2024 at 12:10:34PM +, Wang, Wei W wrote: > On Thursday, July 11, 2024 7:48 PM, Daniel P. Berrangé wrote: > > On Wed, Jul 03, 2024 at 10:49:12PM +0800, Wei Wang wrote: > > > When enforce_cpuid is set to false, the guest is launched with a > > > filtered set of features, meaning t

RE: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-11 Thread Wang, Wei W
On Thursday, July 11, 2024 7:48 PM, Daniel P. Berrangé wrote: > On Wed, Jul 03, 2024 at 10:49:12PM +0800, Wei Wang wrote: > > When enforce_cpuid is set to false, the guest is launched with a > > filtered set of features, meaning that unsupported features by the > > host are removed from the guest's

Re: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-11 Thread Daniel P . Berrangé
On Wed, Jul 03, 2024 at 10:49:12PM +0800, Wei Wang wrote: > When enforce_cpuid is set to false, the guest is launched with a filtered > set of features, meaning that unsupported features by the host are removed > from the guest's vCPU model. This could cause issues for live migration. > For example

RE: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-11 Thread Wang, Wei W
On Friday, July 5, 2024 9:34 PM, Peter Xu wrote: > On Fri, Jul 05, 2024 at 10:22:23AM +, Wang, Wei W wrote: > > On Thursday, July 4, 2024 11:59 PM, Peter Xu wrote: > > > On Thu, Jul 04, 2024 at 03:10:27PM +, Wang, Wei W wrote: > > > > > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c i

Re: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-05 Thread Peter Xu
On Fri, Jul 05, 2024 at 10:22:23AM +, Wang, Wei W wrote: > On Thursday, July 4, 2024 11:59 PM, Peter Xu wrote: > > On Thu, Jul 04, 2024 at 03:10:27PM +, Wang, Wei W wrote: > > > > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c index > > > > > 4c2e6f3a71..7db4fe4ead 100644 > > > > > --

RE: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-05 Thread Wang, Wei W
On Thursday, July 4, 2024 11:59 PM, Peter Xu wrote: > On Thu, Jul 04, 2024 at 03:10:27PM +, Wang, Wei W wrote: > > > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c index > > > > 4c2e6f3a71..7db4fe4ead 100644 > > > > --- a/target/i386/cpu.c > > > > +++ b/target/i386/cpu.c > > > > @@ -8258,

Re: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-04 Thread Peter Xu
On Thu, Jul 04, 2024 at 03:10:27PM +, Wang, Wei W wrote: > > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c index > > > 4c2e6f3a71..7db4fe4ead 100644 > > > --- a/target/i386/cpu.c > > > +++ b/target/i386/cpu.c > > > @@ -8258,7 +8258,7 @@ static Property x86_cpu_properties[] = { > > >

RE: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-04 Thread Wang, Wei W
On Thursday, July 4, 2024 2:04 AM, Peter Xu wrote: > On Wed, Jul 03, 2024 at 10:49:12PM +0800, Wei Wang wrote: > > When enforce_cpuid is set to false, the guest is launched with a > > filtered set of features, meaning that unsupported features by the > > host are removed from the guest's vCPU model

Re: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-03 Thread Peter Xu
On Wed, Jul 03, 2024 at 10:49:12PM +0800, Wei Wang wrote: > When enforce_cpuid is set to false, the guest is launched with a filtered > set of features, meaning that unsupported features by the host are removed > from the guest's vCPU model. This could cause issues for live migration. > For example

[PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-03 Thread Wei Wang
When enforce_cpuid is set to false, the guest is launched with a filtered set of features, meaning that unsupported features by the host are removed from the guest's vCPU model. This could cause issues for live migration. For example, a guest on the source is running with features A and B. If the d