Re: [PATCH v1] virtio-mem: don't warn about THP sizes on a kernel without THP support

2024-09-12 Thread Gavin Shan
On 9/11/24 2:34 AM, David Hildenbrand wrote: If the config directory in sysfs does not exist at all, we are dealing with a system that does not support THPs. Simply use 1 MiB block size then, instead of warning "Could not detect THP size, falling back to ..." and falling back to the default THP s

Re: [PATCH v1] virtio-mem: don't warn about THP sizes on a kernel without THP support

2024-09-10 Thread David Hildenbrand
On 10.09.24 20:26, Michael S. Tsirkin wrote: On Tue, Sep 10, 2024 at 06:34:33PM +0200, David Hildenbrand wrote: If the config directory in sysfs does not exist at all, we are dealing with a system that does not support THPs. Simply use 1 MiB block size then, instead of warning "Could not detect

Re: [PATCH v1] virtio-mem: don't warn about THP sizes on a kernel without THP support

2024-09-10 Thread Michael S. Tsirkin
On Tue, Sep 10, 2024 at 06:34:33PM +0200, David Hildenbrand wrote: > If the config directory in sysfs does not exist at all, we are dealing > with a system that does not support THPs. Simply use 1 MiB block size > then, instead of warning "Could not detect THP size, falling back to > ..." and falli

[PATCH v1] virtio-mem: don't warn about THP sizes on a kernel without THP support

2024-09-10 Thread David Hildenbrand
If the config directory in sysfs does not exist at all, we are dealing with a system that does not support THPs. Simply use 1 MiB block size then, instead of warning "Could not detect THP size, falling back to ..." and falling back to the default THP size. Cc: "Michael S. Tsirkin" Cc: Gavin Shan